Re: [PATCH net] openvswitch: Fix refcount leak on force commit.

2017-03-28 Thread David Miller
From: Jarno Rajahalme Date: Tue, 28 Mar 2017 11:25:26 -0700 > The reference count held for skb needs to be released when the skb's > nfct pointer is cleared regardless of if nf_ct_delete() is called or > not. > > Failing to release the skb's reference cound led to deferred conntrack > cleanup sp

Re: [PATCH net] openvswitch: Fix refcount leak on force commit.

2017-03-28 Thread Joe Stringer
On 28 March 2017 at 11:25, Jarno Rajahalme wrote: > The reference count held for skb needs to be released when the skb's > nfct pointer is cleared regardless of if nf_ct_delete() is called or > not. > > Failing to release the skb's reference cound led to deferred conntrack > cleanup spinning forev

[PATCH net] openvswitch: Fix refcount leak on force commit.

2017-03-28 Thread Jarno Rajahalme
The reference count held for skb needs to be released when the skb's nfct pointer is cleared regardless of if nf_ct_delete() is called or not. Failing to release the skb's reference cound led to deferred conntrack cleanup spinning forever within nf_conntrack_cleanup_net_list() when cleaning up a n