Re: [PATCH net] openvswitch: Fix IPv6 exthdr handling with ct helpers.

2015-09-17 Thread David Miller
From: Joe Stringer Date: Mon, 14 Sep 2015 11:14:50 -0700 > Static code analysis reveals the following bug: > > net/openvswitch/conntrack.c:281 ovs_ct_helper() > warn: unsigned 'protoff' is never less than zero. > > This signedness bug breaks error handling for IPv6 extension hea

Re: [PATCH net] openvswitch: Fix IPv6 exthdr handling with ct helpers.

2015-09-14 Thread Pravin Shelar
On Mon, Sep 14, 2015 at 11:14 AM, Joe Stringer wrote: > Static code analysis reveals the following bug: > > net/openvswitch/conntrack.c:281 ovs_ct_helper() > warn: unsigned 'protoff' is never less than zero. > > This signedness bug breaks error handling for IPv6 extension headers w

[PATCH net] openvswitch: Fix IPv6 exthdr handling with ct helpers.

2015-09-14 Thread Joe Stringer
Static code analysis reveals the following bug: net/openvswitch/conntrack.c:281 ovs_ct_helper() warn: unsigned 'protoff' is never less than zero. This signedness bug breaks error handling for IPv6 extension headers when using conntrack helpers. Fix the error by using a local signe