Re: [PATCH net] nfp: use correct define to return NONE fec

2020-09-17 Thread David Miller
From: Jakub Kicinski Date: Thu, 17 Sep 2020 10:52:57 -0700 > struct ethtool_fecparam carries bitmasks not bit numbers. > We want to return 1 (NONE), not 0. > > Fixes: 0d0870938337 ("nfp: implement ethtool FEC mode settings") > Signed-off-by: Jakub Kicinski Applied and queued up for -stable, th

Re: [PATCH net] nfp: use correct define to return NONE fec

2020-09-17 Thread Simon Horman
On Thu, Sep 17, 2020 at 10:52:57AM -0700, Jakub Kicinski wrote: > struct ethtool_fecparam carries bitmasks not bit numbers. > We want to return 1 (NONE), not 0. > > Fixes: 0d0870938337 ("nfp: implement ethtool FEC mode settings") > Signed-off-by: Jakub Kicinski > --- > drivers/net/ethernet/netro

Re: [PATCH net] nfp: use correct define to return NONE fec

2020-09-17 Thread Jesse Brandeburg
Jakub Kicinski wrote: > struct ethtool_fecparam carries bitmasks not bit numbers. > We want to return 1 (NONE), not 0. > > Fixes: 0d0870938337 ("nfp: implement ethtool FEC mode settings") > Signed-off-by: Jakub Kicinski Good catch! Reviewed-by: Jesse Brandeburg

[PATCH net] nfp: use correct define to return NONE fec

2020-09-17 Thread Jakub Kicinski
struct ethtool_fecparam carries bitmasks not bit numbers. We want to return 1 (NONE), not 0. Fixes: 0d0870938337 ("nfp: implement ethtool FEC mode settings") Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deleti