Re: [PATCH net] nexthop: Fix performance regression in nexthop deletion

2020-10-19 Thread Jakub Kicinski
On Fri, 16 Oct 2020 20:29:14 +0300 Ido Schimmel wrote: > From: Ido Schimmel > > While insertion of 16k nexthops all using the same netdev ('dummy10') > takes less than a second, deletion takes about 130 seconds: Applied, thank you!

Re: [PATCH net] nexthop: Fix performance regression in nexthop deletion

2020-10-17 Thread Nikolay Aleksandrov
On Fri, 2020-10-16 at 20:29 +0300, Ido Schimmel wrote: > From: Ido Schimmel > > While insertion of 16k nexthops all using the same netdev ('dummy10') > takes less than a second, deletion takes about 130 seconds: > > # time -p ip -b nexthop.batch > real 0.29 > user 0.01 > sys 0.15 > > # time -p

Re: [PATCH net] nexthop: Fix performance regression in nexthop deletion

2020-10-16 Thread David Ahern
On 10/16/20 11:29 AM, Ido Schimmel wrote: > From: Ido Schimmel > > While insertion of 16k nexthops all using the same netdev ('dummy10') > takes less than a second, deletion takes about 130 seconds: > > # time -p ip -b nexthop.batch > real 0.29 > user 0.01 > sys 0.15 > > # time -p ip link set d

Re: [PATCH net] nexthop: Fix performance regression in nexthop deletion

2020-10-16 Thread Jesse Brandeburg
Ido Schimmel wrote: > From: Ido Schimmel > > While insertion of 16k nexthops all using the same netdev ('dummy10') > takes less than a second, deletion takes about 130 seconds: > > # time -p ip -b nexthop.batch > real 0.29 > user 0.01 > sys 0.15 > > # time -p ip link set dev dummy10 down > rea

[PATCH net] nexthop: Fix performance regression in nexthop deletion

2020-10-16 Thread Ido Schimmel
From: Ido Schimmel While insertion of 16k nexthops all using the same netdev ('dummy10') takes less than a second, deletion takes about 130 seconds: # time -p ip -b nexthop.batch real 0.29 user 0.01 sys 0.15 # time -p ip link set dev dummy10 down real 131.03 user 0.06 sys 0.52 This is because