Re: [PATCH net] netns: fix GFP flags in rtnl_net_notifyid()

2019-10-23 Thread Nicolas Dichtel
Le 23/10/2019 à 18:39, Guillaume Nault a écrit : > In rtnl_net_notifyid(), we certainly can't pass a null GFP flag to > rtnl_notify(). A GFP_KERNEL flag would be fine in most circumstances, > but there are a few paths calling rtnl_net_notifyid() from atomic > context or from RCU critical sections.

[PATCH net] netns: fix GFP flags in rtnl_net_notifyid()

2019-10-23 Thread Guillaume Nault
In rtnl_net_notifyid(), we certainly can't pass a null GFP flag to rtnl_notify(). A GFP_KERNEL flag would be fine in most circumstances, but there are a few paths calling rtnl_net_notifyid() from atomic context or from RCU critical sections. The later also precludes the use of gfp_any() as it would

Re: [RFC PATCH net] netns: fix GFP flags in rtnl_net_notifyid()

2019-10-18 Thread Guillaume Nault
On Fri, Oct 18, 2019 at 01:55:46PM -0700, Pravin Shelar wrote: > On Sun, Oct 13, 2019 at 3:22 PM Guillaume Nault wrote: > > The point of my RFC is to know if it's possible to avoid all these > > gfp_t flags, by allowing ovs_vport_cmd_fill_info() to sleep (at least > > I'd like to figure out if it'

Re: [RFC PATCH net] netns: fix GFP flags in rtnl_net_notifyid()

2019-10-18 Thread Pravin Shelar
On Sun, Oct 13, 2019 at 3:22 PM Guillaume Nault wrote: > > On Sun, Oct 13, 2019 at 12:09:43PM -0700, Pravin Shelar wrote: > > On Thu, Oct 10, 2019 at 12:07 PM Guillaume Nault wrote: > > > > > > In rtnl_net_notifyid(), we certainly can't pass a null GFP flag to > > > rtnl_notify(). A GFP_KERNEL fl

Re: [RFC PATCH net] netns: fix GFP flags in rtnl_net_notifyid()

2019-10-13 Thread Guillaume Nault
On Sun, Oct 13, 2019 at 12:09:43PM -0700, Pravin Shelar wrote: > On Thu, Oct 10, 2019 at 12:07 PM Guillaume Nault wrote: > > > > In rtnl_net_notifyid(), we certainly can't pass a null GFP flag to > > rtnl_notify(). A GFP_KERNEL flag would be fine in most circumstances, > > but there are a few path

Re: [RFC PATCH net] netns: fix GFP flags in rtnl_net_notifyid()

2019-10-13 Thread Pravin Shelar
On Thu, Oct 10, 2019 at 12:07 PM Guillaume Nault wrote: > > In rtnl_net_notifyid(), we certainly can't pass a null GFP flag to > rtnl_notify(). A GFP_KERNEL flag would be fine in most circumstances, > but there are a few paths calling rtnl_net_notifyid() from atomic > context or from RCU critical

Re: [RFC PATCH net] netns: fix GFP flags in rtnl_net_notifyid()

2019-10-13 Thread David Miller
From: Guillaume Nault Date: Thu, 10 Oct 2019 21:07:29 +0200 > Before I spend more time on this, do we have a chance to make > ovs_vport_cmd_fill_info() and __dev_notify_flags() sleepable? > I'd like to avoid passing GFP flags along these call chains, if at all > possible. OVS folks, please weigh

[RFC PATCH net] netns: fix GFP flags in rtnl_net_notifyid()

2019-10-10 Thread Guillaume Nault
In rtnl_net_notifyid(), we certainly can't pass a null GFP flag to rtnl_notify(). A GFP_KERNEL flag would be fine in most circumstances, but there are a few paths calling rtnl_net_notifyid() from atomic context or from RCU critical section. The later also precludes the use of gfp_any() as it wouldn