Re: [PATCH net] netlink: make sure -EBUSY won't escape from netlink_insert

2015-09-28 Thread David Miller
From: Christoph Paasch Date: Wed, 16 Sep 2015 22:41:14 -0700 > Hello, > > On 10/08/15 - 11:00:15, David Miller wrote: >> From: Daniel Borkmann >> Date: Fri, 7 Aug 2015 00:26:41 +0200 >> > Linus reports the following deadlock on rtnl_mutex; triggered only >> > once so far (extract): >> ... >>

Re: [PATCH net] netlink: make sure -EBUSY won't escape from netlink_insert

2015-09-18 Thread Daniel Borkmann
On 09/18/2015 04:09 AM, Herbert Xu wrote: On Thu, Sep 17, 2015 at 11:47:12AM -0700, Linus Torvalds wrote: On Wed, Sep 16, 2015 at 10:41 PM, Christoph Paasch wrote: can this patch get queued up for 4.1 as well? It seems to fix a similar issue in 4.1.6. I think Herbert has an additional patch

Re: [PATCH net] netlink: make sure -EBUSY won't escape from netlink_insert

2015-09-17 Thread Herbert Xu
On Thu, Sep 17, 2015 at 11:47:12AM -0700, Linus Torvalds wrote: > On Wed, Sep 16, 2015 at 10:41 PM, Christoph Paasch > wrote: > > > > can this patch get queued up for 4.1 as well? > > It seems to fix a similar issue in 4.1.6. > > I think Herbert has an additional patch for this issue. But yes, I

Re: [PATCH net] netlink: make sure -EBUSY won't escape from netlink_insert

2015-09-17 Thread Linus Torvalds
On Wed, Sep 16, 2015 at 10:41 PM, Christoph Paasch wrote: > > can this patch get queued up for 4.1 as well? > It seems to fix a similar issue in 4.1.6. I think Herbert has an additional patch for this issue. But yes, I think should be scheduled for stable. Herbert? Linus -- To un

Re: [PATCH net] netlink: make sure -EBUSY won't escape from netlink_insert

2015-09-16 Thread Christoph Paasch
Hello, On 10/08/15 - 11:00:15, David Miller wrote: > From: Daniel Borkmann > Date: Fri, 7 Aug 2015 00:26:41 +0200 > > Linus reports the following deadlock on rtnl_mutex; triggered only > > once so far (extract): > ... > > It seems so far plausible that the recursive call into rtnetlink_rcv() >

Re: [PATCH net] netlink: make sure -EBUSY won't escape from netlink_insert

2015-08-10 Thread David Miller
From: Daniel Borkmann Date: Fri, 7 Aug 2015 00:26:41 +0200 > Linus reports the following deadlock on rtnl_mutex; triggered only > once so far (extract): ... > It seems so far plausible that the recursive call into rtnetlink_rcv() > looks suspicious. One way, where this could trigger is that the

Re: [PATCH net] netlink: make sure -EBUSY won't escape from netlink_insert

2015-08-08 Thread Thomas Graf
On 08/07/15 at 12:26am, Daniel Borkmann wrote: > Linus reports the following deadlock on rtnl_mutex; triggered only > once so far (extract): > [...] > Reference: http://thread.gmane.org/gmane.linux.network/372676 > Reported-by: Linus Torvalds > Signed-off-by: Daniel Borkmann Acked-by: Thomas G

Re: [PATCH net] netlink: make sure -EBUSY won't escape from netlink_insert

2015-08-06 Thread Herbert Xu
On Fri, Aug 07, 2015 at 12:26:41AM +0200, Daniel Borkmann wrote: > > Reference: http://thread.gmane.org/gmane.linux.network/372676 > Reported-by: Linus Torvalds > Signed-off-by: Daniel Borkmann Acked-by: Herbert Xu But as I said earlier, this should not happen and if it does, then our rhashtab

[PATCH net] netlink: make sure -EBUSY won't escape from netlink_insert

2015-08-06 Thread Daniel Borkmann
Linus reports the following deadlock on rtnl_mutex; triggered only once so far (extract): [12236.694209] NetworkManager D 00013b80 0 1047 1 0x [12236.694218] 88003f902640 815d15a9 0018 [12236.694224] 880119538000 88003f