Re: [PATCH net] netdevsim: Restore per-network namespace accounting for fib entries

2019-08-29 Thread Jiri Pirko
Thu, Aug 29, 2019 at 02:54:39PM CEST, dsah...@gmail.com wrote: >On 8/29/19 12:28 AM, Jiri Pirko wrote: >> Wed, Aug 28, 2019 at 11:26:03PM CEST, dsah...@gmail.com wrote: >>> On 8/28/19 4:37 AM, Jiri Pirko wrote: Tue, Aug 06, 2019 at 09:15:17PM CEST, dsah...@kernel.org wrote: > From: David A

Re: [PATCH net] netdevsim: Restore per-network namespace accounting for fib entries

2019-08-29 Thread David Ahern
On 8/29/19 12:28 AM, Jiri Pirko wrote: > Wed, Aug 28, 2019 at 11:26:03PM CEST, dsah...@gmail.com wrote: >> On 8/28/19 4:37 AM, Jiri Pirko wrote: >>> Tue, Aug 06, 2019 at 09:15:17PM CEST, dsah...@kernel.org wrote: From: David Ahern Prior to the commit in the fixes tag, the resource c

Re: [PATCH net] netdevsim: Restore per-network namespace accounting for fib entries

2019-08-28 Thread Jiri Pirko
Wed, Aug 28, 2019 at 11:26:03PM CEST, dsah...@gmail.com wrote: >On 8/28/19 4:37 AM, Jiri Pirko wrote: >> Tue, Aug 06, 2019 at 09:15:17PM CEST, dsah...@kernel.org wrote: >>> From: David Ahern >>> >>> Prior to the commit in the fixes tag, the resource controller in netdevsim >>> tracked fib entries

Re: [PATCH net] netdevsim: Restore per-network namespace accounting for fib entries

2019-08-28 Thread David Ahern
On 8/28/19 4:37 AM, Jiri Pirko wrote: > Tue, Aug 06, 2019 at 09:15:17PM CEST, dsah...@kernel.org wrote: >> From: David Ahern >> >> Prior to the commit in the fixes tag, the resource controller in netdevsim >> tracked fib entries and rules per network namespace. Restore that behavior. > > David, p

Re: [PATCH net] netdevsim: Restore per-network namespace accounting for fib entries

2019-08-28 Thread Jiri Pirko
Tue, Aug 06, 2019 at 09:15:17PM CEST, dsah...@kernel.org wrote: >From: David Ahern > >Prior to the commit in the fixes tag, the resource controller in netdevsim >tracked fib entries and rules per network namespace. Restore that behavior. David, please help me understand. If the counters are per-d

Re: [PATCH net] netdevsim: Restore per-network namespace accounting for fib entries

2019-08-13 Thread Jiri Pirko
Tue, Aug 13, 2019 at 07:40:54PM CEST, da...@davemloft.net wrote: >From: Jiri Pirko >Date: Tue, 13 Aug 2019 09:14:45 +0200 > >> Mon, Aug 12, 2019 at 05:28:02PM CEST, da...@davemloft.net wrote: >>>From: Jiri Pirko >>>Date: Mon, 12 Aug 2019 10:36:35 +0200 >>> I understand it with real devices,

Re: [PATCH net] netdevsim: Restore per-network namespace accounting for fib entries

2019-08-13 Thread David Miller
From: Jiri Pirko Date: Tue, 13 Aug 2019 09:14:45 +0200 > Mon, Aug 12, 2019 at 05:28:02PM CEST, da...@davemloft.net wrote: >>From: Jiri Pirko >>Date: Mon, 12 Aug 2019 10:36:35 +0200 >> >>> I understand it with real devices, but dummy testing device, who's >>> purpose is just to test API. Why? >>

Re: [PATCH net] netdevsim: Restore per-network namespace accounting for fib entries

2019-08-13 Thread Jiri Pirko
Tue, Aug 13, 2019 at 04:41:18PM CEST, dsah...@gmail.com wrote: >On 8/13/19 1:14 AM, Jiri Pirko wrote: >> Mon, Aug 12, 2019 at 05:28:02PM CEST, da...@davemloft.net wrote: >>> From: Jiri Pirko >>> Date: Mon, 12 Aug 2019 10:36:35 +0200 >>> I understand it with real devices, but dummy testing dev

Re: [PATCH net] netdevsim: Restore per-network namespace accounting for fib entries

2019-08-13 Thread David Ahern
On 8/13/19 1:14 AM, Jiri Pirko wrote: > Mon, Aug 12, 2019 at 05:28:02PM CEST, da...@davemloft.net wrote: >> From: Jiri Pirko >> Date: Mon, 12 Aug 2019 10:36:35 +0200 >> >>> I understand it with real devices, but dummy testing device, who's >>> purpose is just to test API. Why? >> >> Because you'll

Re: [PATCH net] netdevsim: Restore per-network namespace accounting for fib entries

2019-08-13 Thread Jiri Pirko
Mon, Aug 12, 2019 at 05:28:02PM CEST, da...@davemloft.net wrote: >From: Jiri Pirko >Date: Mon, 12 Aug 2019 10:36:35 +0200 > >> I understand it with real devices, but dummy testing device, who's >> purpose is just to test API. Why? > >Because you'll break all of the wonderful testing infrastructure

Re: [PATCH net] netdevsim: Restore per-network namespace accounting for fib entries

2019-08-12 Thread David Miller
From: Jiri Pirko Date: Mon, 12 Aug 2019 10:36:35 +0200 > I understand it with real devices, but dummy testing device, who's > purpose is just to test API. Why? Because you'll break all of the wonderful testing infrastructure people like David have created.

Re: [PATCH net] netdevsim: Restore per-network namespace accounting for fib entries

2019-08-12 Thread Jiri Pirko
Mon, Aug 12, 2019 at 06:02:18AM CEST, da...@davemloft.net wrote: >From: David Ahern >Date: Tue, 6 Aug 2019 12:15:17 -0700 > >> From: David Ahern >> >> Prior to the commit in the fixes tag, the resource controller in netdevsim >> tracked fib entries and rules per network namespace. Restore that

Re: [PATCH net] netdevsim: Restore per-network namespace accounting for fib entries

2019-08-11 Thread David Miller
From: David Ahern Date: Tue, 6 Aug 2019 12:15:17 -0700 > From: David Ahern > > Prior to the commit in the fixes tag, the resource controller in netdevsim > tracked fib entries and rules per network namespace. Restore that behavior. > > Fixes: 5fc494225c1e ("netdevsim: create devlink instance

Re: [PATCH net] netdevsim: Restore per-network namespace accounting for fib entries

2019-08-07 Thread David Ahern
On 8/7/19 7:07 AM, Jiri Pirko wrote: > > Yeah. I believe it was a mistake to add it in the first place. Abuses > netdevsim for something it is not. I'm fine to use devlink the way you > want to after we conclude 2), but outside netdevsim. > > Again, netdevsim is there for config api testing purpo

Re: [PATCH net] netdevsim: Restore per-network namespace accounting for fib entries

2019-08-07 Thread Jiri Pirko
Wed, Aug 07, 2019 at 02:39:56PM CEST, dsah...@gmail.com wrote: >On 8/7/19 12:27 AM, Jiri Pirko wrote: >> Wed, Aug 07, 2019 at 12:32:14AM CEST, jakub.kicin...@netronome.com wrote: >>> On Tue, 6 Aug 2019 12:15:17 -0700, David Ahern wrote: From: David Ahern Prior to the commit in the

Re: [PATCH net] netdevsim: Restore per-network namespace accounting for fib entries

2019-08-07 Thread David Ahern
On 8/7/19 12:27 AM, Jiri Pirko wrote: > Wed, Aug 07, 2019 at 12:32:14AM CEST, jakub.kicin...@netronome.com wrote: >> On Tue, 6 Aug 2019 12:15:17 -0700, David Ahern wrote: >>> From: David Ahern >>> >>> Prior to the commit in the fixes tag, the resource controller in netdevsim >>> tracked fib entri

Re: [PATCH net] netdevsim: Restore per-network namespace accounting for fib entries

2019-08-06 Thread Jiri Pirko
Wed, Aug 07, 2019 at 12:32:14AM CEST, jakub.kicin...@netronome.com wrote: >On Tue, 6 Aug 2019 12:15:17 -0700, David Ahern wrote: >> From: David Ahern >> >> Prior to the commit in the fixes tag, the resource controller in netdevsim >> tracked fib entries and rules per network namespace. Restore t

Re: [PATCH net] netdevsim: Restore per-network namespace accounting for fib entries

2019-08-06 Thread Jakub Kicinski
On Tue, 6 Aug 2019 12:15:17 -0700, David Ahern wrote: > From: David Ahern > > Prior to the commit in the fixes tag, the resource controller in netdevsim > tracked fib entries and rules per network namespace. Restore that behavior. > > Fixes: 5fc494225c1e ("netdevsim: create devlink instance per

[PATCH net] netdevsim: Restore per-network namespace accounting for fib entries

2019-08-06 Thread David Ahern
From: David Ahern Prior to the commit in the fixes tag, the resource controller in netdevsim tracked fib entries and rules per network namespace. Restore that behavior. Fixes: 5fc494225c1e ("netdevsim: create devlink instance per netdevsim instance") Signed-off-by: David Ahern --- drivers/net