Re: [PATCH net] net_sched: reject silly cell_log in qdisc_get_rtab()

2021-01-15 Thread Jakub Kicinski
On Thu, 14 Jan 2021 10:03:39 -0800 Cong Wang wrote: > On Thu, Jan 14, 2021 at 8:06 AM Eric Dumazet wrote: > > > > From: Eric Dumazet > > > > iproute2 probably never goes beyond 8 for the cell exponent, > > but stick to the max shift exponent for signed 32bit. > > > > UBSAN reported: > > UBSAN: sh

Re: [PATCH net] net_sched: reject silly cell_log in qdisc_get_rtab()

2021-01-14 Thread Cong Wang
On Thu, Jan 14, 2021 at 8:06 AM Eric Dumazet wrote: > > From: Eric Dumazet > > iproute2 probably never goes beyond 8 for the cell exponent, > but stick to the max shift exponent for signed 32bit. > > UBSAN reported: > UBSAN: shift-out-of-bounds in net/sched/sch_api.c:389:22 > shift exponent 130 i

[PATCH net] net_sched: reject silly cell_log in qdisc_get_rtab()

2021-01-14 Thread Eric Dumazet
From: Eric Dumazet iproute2 probably never goes beyond 8 for the cell exponent, but stick to the max shift exponent for signed 32bit. UBSAN reported: UBSAN: shift-out-of-bounds in net/sched/sch_api.c:389:22 shift exponent 130 is too large for 32-bit type 'int' CPU: 1 PID: 8450 Comm: syz-executor