Re: [PATCH net] net_sched: prio: properly report out of memory errors

2016-06-12 Thread Eric Dumazet
On Sun, 2016-06-12 at 20:45 -0700, Cong Wang wrote: > On Sun, Jun 12, 2016 at 4:21 PM, Eric Dumazet wrote: > > + struct Qdisc *child; > > + > > + if (q->queues[i] != &noop_qdisc) > > + continue; > > + > > + child = qdisc_create_dflt(s

Re: [PATCH net] net_sched: prio: properly report out of memory errors

2016-06-12 Thread Cong Wang
On Sun, Jun 12, 2016 at 4:21 PM, Eric Dumazet wrote: > + struct Qdisc *child; > + > + if (q->queues[i] != &noop_qdisc) > + continue; > + > + child = qdisc_create_dflt(sch->dev_queue, &pfifo_qdisc_ops, > +

Re: [PATCH net] net_sched: prio: properly report out of memory errors

2016-06-12 Thread David Miller
From: Eric Dumazet Date: Sun, 12 Jun 2016 16:21:47 -0700 > From: Eric Dumazet > > At Qdisc creation or change time, prio_tune() creates missing > pfifo qdiscs but does not return an error code if one > qdisc could not be allocated. > > Leaving a qdisc in non operational state without telling u

[PATCH net] net_sched: prio: properly report out of memory errors

2016-06-12 Thread Eric Dumazet
From: Eric Dumazet At Qdisc creation or change time, prio_tune() creates missing pfifo qdiscs but does not return an error code if one qdisc could not be allocated. Leaving a qdisc in non operational state without telling user anything about this problem is not good. Also, testing if we replace