Re: [PATCH net] net: watchdog: hold device global xmit lock during tx disable

2021-02-08 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Fri, 5 Feb 2021 17:37:32 -0800 you wrote: > Prevent netif_tx_disable() running concurrently with dev_watchdog() by > taking the device global xmit lock. Otherwise, the recommended: > > netif_carrier_off(dev); >

Re: [PATCH net] net: watchdog: hold device global xmit lock during tx disable

2021-02-08 Thread Jakub Kicinski
On Fri, 5 Feb 2021 17:37:32 -0800 Edwin Peer wrote: > Prevent netif_tx_disable() running concurrently with dev_watchdog() by > taking the device global xmit lock. Otherwise, the recommended: > > netif_carrier_off(dev); > netif_tx_disable(dev); > > driver shutdown sequence can happen

[PATCH net] net: watchdog: hold device global xmit lock during tx disable

2021-02-05 Thread Edwin Peer
Prevent netif_tx_disable() running concurrently with dev_watchdog() by taking the device global xmit lock. Otherwise, the recommended: netif_carrier_off(dev); netif_tx_disable(dev); driver shutdown sequence can happen after the watchdog has already checked carrier, resulting in po