Re: [PATCH net] net: validate untrusted gso packets without csum offload

2019-02-18 Thread Willem de Bruijn
On Mon, Feb 18, 2019 at 2:12 PM Willem de Bruijn wrote: > > On Fri, Feb 15, 2019 at 12:15 PM Willem de Bruijn > wrote: > > > > From: Willem de Bruijn > > > > Syzkaller again found a path to a kernel crash through bad gso input. > > By building an excessively large packet to cause an skb field to

Re: [PATCH net] net: validate untrusted gso packets without csum offload

2019-02-18 Thread Willem de Bruijn
On Fri, Feb 15, 2019 at 12:15 PM Willem de Bruijn wrote: > > From: Willem de Bruijn > > Syzkaller again found a path to a kernel crash through bad gso input. > By building an excessively large packet to cause an skb field to wrap. > > If VIRTIO_NET_HDR_F_NEEDS_CSUM was set this would have been dr

Re: [PATCH net] net: validate untrusted gso packets without csum offload

2019-02-15 Thread David Miller
From: Willem de Bruijn Date: Fri, 15 Feb 2019 12:15:47 -0500 > From: Willem de Bruijn > > Syzkaller again found a path to a kernel crash through bad gso input. > By building an excessively large packet to cause an skb field to wrap. > > If VIRTIO_NET_HDR_F_NEEDS_CSUM was set this would have be

Re: [PATCH net] net: validate untrusted gso packets without csum offload

2019-02-15 Thread Eric Dumazet
On 02/15/2019 09:15 AM, Willem de Bruijn wrote: > From: Willem de Bruijn > > Syzkaller again found a path to a kernel crash through bad gso input. > By building an excessively large packet to cause an skb field to wrap. > > If VIRTIO_NET_HDR_F_NEEDS_CSUM was set this would have been dropped i

[PATCH net] net: validate untrusted gso packets without csum offload

2019-02-15 Thread Willem de Bruijn
From: Willem de Bruijn Syzkaller again found a path to a kernel crash through bad gso input. By building an excessively large packet to cause an skb field to wrap. If VIRTIO_NET_HDR_F_NEEDS_CSUM was set this would have been dropped in skb_partial_csum_set. GSO packets that do not set checksum o