Re: [PATCH net] net: stmmac: fix completely hung TX when using TSO

2017-06-06 Thread David Miller
From: Niklas Cassel Date: Tue, 6 Jun 2017 09:25:00 +0200 > stmmac_tso_allocator can fail to set the Last Descriptor bit > on a descriptor that actually was the last descriptor. > > This happens when the buffer of the last descriptor ends > up having a size of exactly TSO_MAX_BUFF_SIZE. > > When

Re: [PATCH net] net: stmmac: fix completely hung TX when using TSO

2017-06-06 Thread Florian Fainelli
On 06/06/2017 12:25 AM, Niklas Cassel wrote: > stmmac_tso_allocator can fail to set the Last Descriptor bit > on a descriptor that actually was the last descriptor. > > This happens when the buffer of the last descriptor ends > up having a size of exactly TSO_MAX_BUFF_SIZE. > > When the IP even

Re: [PATCH net] net: stmmac: fix completely hung TX when using TSO

2017-06-06 Thread Niklas Cassel
On 06/06/2017 10:00 AM, Giuseppe CAVALLARO wrote: > Hi Niklas Hello Peppe, Alex > > I get the point and I acked the patch but Alex, please, can you confirm > that this issue has never seen on your boxes where the TSO has been > fully tested? The initial development (commit f748be531) introduces

Re: [PATCH net] net: stmmac: fix completely hung TX when using TSO

2017-06-06 Thread Alexandre Torgue
Hi Guys, On 06/06/2017 10:00 AM, Giuseppe CAVALLARO wrote: Hi Niklas I get the point and I acked the patch but Alex, please, can you confirm that this issue has never seen on your boxes where the TSO has been fully tested? The initial development (commit f748be531) introduces the following:

Re: [PATCH net] net: stmmac: fix completely hung TX when using TSO

2017-06-06 Thread Giuseppe CAVALLARO
Hi Niklas I get the point and I acked the patch but Alex, please, can you confirm that this issue has never seen on your boxes where the TSO has been fully tested? The initial development (commit f748be531) introduces the following: (last_segment) && (buff_size < TSO_MAX_BUFF_SIZE), ... On 6

[PATCH net] net: stmmac: fix completely hung TX when using TSO

2017-06-06 Thread Niklas Cassel
stmmac_tso_allocator can fail to set the Last Descriptor bit on a descriptor that actually was the last descriptor. This happens when the buffer of the last descriptor ends up having a size of exactly TSO_MAX_BUFF_SIZE. When the IP eventually reaches the next last descriptor, which actually has t