Re: [PATCH net] net: stmmac: dwmac-meson8b: Fix signedness bug in probe

2019-09-27 Thread David Miller
From: Dan Carpenter Date: Wed, 25 Sep 2019 13:58:22 +0300 > The "dwmac->phy_mode" is an enum and in this context GCC treats it as > an unsigned int so the error handling is never triggered. > > Fixes: 566e82516253 ("net: stmmac: add a glue driver for the Amlogic Meson 8b > / GXBB DWMAC") > Sign

Re: [PATCH net] net: stmmac: dwmac-meson8b: Fix signedness bug in probe

2019-09-26 Thread Martin Blumenstingl
+Cc linux-amlogic mailing list On Wed, Sep 25, 2019 at 12:59 PM Dan Carpenter wrote: > > The "dwmac->phy_mode" is an enum and in this context GCC treats it as > an unsigned int so the error handling is never triggered. > > Fixes: 566e82516253 ("net: stmmac: add a glue driver for the Amlogic Meson

[PATCH net] net: stmmac: dwmac-meson8b: Fix signedness bug in probe

2019-09-25 Thread Dan Carpenter
The "dwmac->phy_mode" is an enum and in this context GCC treats it as an unsigned int so the error handling is never triggered. Fixes: 566e82516253 ("net: stmmac: add a glue driver for the Amlogic Meson 8b / GXBB DWMAC") Signed-off-by: Dan Carpenter --- drivers/net/ethernet/stmicro/stmmac/dwmac