Re: [PATCH net] net: stmmac: Use hrtimer for TX coalescing

2020-11-24 Thread Jakub Kicinski
On Tue, 24 Nov 2020 05:11:27 +0100 Vincent Whitchurch wrote: > On Tue, Nov 24, 2020 at 01:46:00AM +0100, Jakub Kicinski wrote: > > On Fri, 20 Nov 2020 16:02:08 +0100 Vincent Whitchurch wrote: > > > This driver uses a normal timer for TX coalescing, which means that the > > > with the default tx-u

Re: [PATCH net] net: stmmac: Use hrtimer for TX coalescing

2020-11-23 Thread Vincent Whitchurch
On Tue, Nov 24, 2020 at 01:46:00AM +0100, Jakub Kicinski wrote: > On Fri, 20 Nov 2020 16:02:08 +0100 Vincent Whitchurch wrote: > > This driver uses a normal timer for TX coalescing, which means that the > > with the default tx-usecs of 1000 microseconds the cleanups actually > > happen 10 ms or mor

Re: [PATCH net] net: stmmac: Use hrtimer for TX coalescing

2020-11-23 Thread Jakub Kicinski
On Fri, 20 Nov 2020 16:02:08 +0100 Vincent Whitchurch wrote: > This driver uses a normal timer for TX coalescing, which means that the > with the default tx-usecs of 1000 microseconds the cleanups actually > happen 10 ms or more later with HZ=100. This leads to very low > througput with TCP when b

[PATCH net] net: stmmac: Use hrtimer for TX coalescing

2020-11-20 Thread Vincent Whitchurch
This driver uses a normal timer for TX coalescing, which means that the with the default tx-usecs of 1000 microseconds the cleanups actually happen 10 ms or more later with HZ=100. This leads to very low througput with TCP when bridged to a slow link such as a 4G modem. Fix this by using an hrtim