Re: [PATCH net] net: socionext: netsec: always grab descriptor lock

2019-10-01 Thread David Miller
From: Lorenzo Bianconi Date: Tue, 1 Oct 2019 10:33:51 +0200 > Always acquire tx descriptor spinlock even if a xdp program is not loaded > on the netsec device since ndo_xdp_xmit can run concurrently with > netsec_netdev_start_xmit and netsec_clean_tx_dring. This can happen > loading a xdp progra

Re: [PATCH net] net: socionext: netsec: always grab descriptor lock

2019-10-01 Thread Toke Høiland-Jørgensen
Lorenzo Bianconi writes: > Always acquire tx descriptor spinlock even if a xdp program is not loaded > on the netsec device since ndo_xdp_xmit can run concurrently with > netsec_netdev_start_xmit and netsec_clean_tx_dring. This can happen > loading a xdp program on a different device (e.g virtio-

Re: [PATCH net] net: socionext: netsec: always grab descriptor lock

2019-10-01 Thread Ilias Apalodimas
On Tue, Oct 01, 2019 at 10:33:51AM +0200, Lorenzo Bianconi wrote: > Always acquire tx descriptor spinlock even if a xdp program is not loaded > on the netsec device since ndo_xdp_xmit can run concurrently with > netsec_netdev_start_xmit and netsec_clean_tx_dring. This can happen > loading a xdp pro

[PATCH net] net: socionext: netsec: always grab descriptor lock

2019-10-01 Thread Lorenzo Bianconi
Always acquire tx descriptor spinlock even if a xdp program is not loaded on the netsec device since ndo_xdp_xmit can run concurrently with netsec_netdev_start_xmit and netsec_clean_tx_dring. This can happen loading a xdp program on a different device (e.g virtio-net) and xdp_do_redirect_map/xdp_do