Re: [PATCH net] net: skb_segment() should not return NULL

2018-07-21 Thread David Miller
From: Eric Dumazet Date: Thu, 19 Jul 2018 16:04:38 -0700 > syzbot caught a NULL deref [1], caused by skb_segment() > > skb_segment() has many "goto err;" that assume the @err variable > contains -ENOMEM. > > A successful call to __skb_linearize() should not clear @err, > otherwise a subsequent

Re: [PATCH net] net: skb_segment() should not return NULL

2018-07-19 Thread Alexander Duyck
On Thu, Jul 19, 2018 at 4:04 PM, Eric Dumazet wrote: > syzbot caught a NULL deref [1], caused by skb_segment() > > skb_segment() has many "goto err;" that assume the @err variable > contains -ENOMEM. > > A successful call to __skb_linearize() should not clear @err, > otherwise a subsequent memory

[PATCH net] net: skb_segment() should not return NULL

2018-07-19 Thread Eric Dumazet
syzbot caught a NULL deref [1], caused by skb_segment() skb_segment() has many "goto err;" that assume the @err variable contains -ENOMEM. A successful call to __skb_linearize() should not clear @err, otherwise a subsequent memory allocation error could return NULL. While we are at it, we might