Re: [PATCH net] net: selinux: fix memory leak in selinux_netlbl_socket_post_create()

2019-03-08 Thread maowenan
On 2019/3/8 21:20, Paul Moore wrote: > On Fri, Mar 8, 2019 at 1:31 AM maowenan wrote: >> On 2019/3/8 4:36, Paul Moore wrote: >>> On Wed, Mar 6, 2019 at 9:44 PM Mao Wenan wrote: If netlbl_sock_setattr() is failed, it directly returns rc and forgets to free secattr. BUG:

Re: [PATCH net] net: selinux: fix memory leak in selinux_netlbl_socket_post_create()

2019-03-08 Thread Paul Moore
On Fri, Mar 8, 2019 at 1:31 AM maowenan wrote: > On 2019/3/8 4:36, Paul Moore wrote: > > On Wed, Mar 6, 2019 at 9:44 PM Mao Wenan wrote: > >> > >> If netlbl_sock_setattr() is failed, it directly returns rc and forgets > >> to free secattr. > >> > >> BUG: memory leak > >> unreferenced object 0xfff

Re: [PATCH net] net: selinux: fix memory leak in selinux_netlbl_socket_post_create()

2019-03-07 Thread maowenan
On 2019/3/8 4:36, Paul Moore wrote: > On Wed, Mar 6, 2019 at 9:44 PM Mao Wenan wrote: >> >> If netlbl_sock_setattr() is failed, it directly returns rc and forgets >> to free secattr. >> >> BUG: memory leak >> unreferenced object 0x8883c3ea4200 (size 2664): >> comm "syz-executor.2", pid 88

Re: [PATCH net] net: selinux: fix memory leak in selinux_netlbl_socket_post_create()

2019-03-07 Thread Paul Moore
On Wed, Mar 6, 2019 at 9:44 PM Mao Wenan wrote: > > If netlbl_sock_setattr() is failed, it directly returns rc and forgets > to free secattr. > > BUG: memory leak > unreferenced object 0x8883c3ea4200 (size 2664): > comm "syz-executor.2", pid 8813, jiffies 4297264419 (age 156.090s) > hex du

[PATCH net] net: selinux: fix memory leak in selinux_netlbl_socket_post_create()

2019-03-06 Thread Mao Wenan
If netlbl_sock_setattr() is failed, it directly returns rc and forgets to free secattr. BUG: memory leak unreferenced object 0x8883c3ea4200 (size 2664): comm "syz-executor.2", pid 8813, jiffies 4297264419 (age 156.090s) hex dump (first 32 bytes): 7f 00 00 01 7f 00 00 01 eb 7f ed 71 4e