Re: [PATCH net] net: sched: put back q.qlen into a single location

2019-03-08 Thread Paolo Abeni
Hi, Thank you for fixing this! On Thu, 2019-02-28 at 12:55 -0800, Eric Dumazet wrote: > Later (net-next) we might revert this patch by tracking all these > qlen uses and replace them by a more efficient method (not having > to access a precise qlen, but an empty/non_empty status that might > be l

Re: [PATCH net] net: sched: put back q.qlen into a single location

2019-03-03 Thread John Fastabend
On 2/28/19 12:55 PM, Eric Dumazet wrote: > In the series fc8b81a5981f ("Merge branch 'lockless-qdisc-series'") > John made the assumption that the data path had no need to read > the qdisc qlen (number of packets in the qdisc). > > It is true when pfifo_fast is used as the root qdisc, or as direct

Re: [PATCH net] net: sched: put back q.qlen into a single location

2019-03-02 Thread David Miller
From: Eric Dumazet Date: Thu, 28 Feb 2019 12:55:43 -0800 > In the series fc8b81a5981f ("Merge branch 'lockless-qdisc-series'") > John made the assumption that the data path had no need to read > the qdisc qlen (number of packets in the qdisc). > > It is true when pfifo_fast is used as the root q

Re: [PATCH net] net: sched: put back q.qlen into a single location

2019-03-01 Thread David Miller
From: Eric Dumazet Date: Thu, 28 Feb 2019 12:55:43 -0800 > In the series fc8b81a5981f ("Merge branch 'lockless-qdisc-series'") > John made the assumption that the data path had no need to read > the qdisc qlen (number of packets in the qdisc). > > It is true when pfifo_fast is used as the root q

[PATCH net] net: sched: put back q.qlen into a single location

2019-02-28 Thread Eric Dumazet
In the series fc8b81a5981f ("Merge branch 'lockless-qdisc-series'") John made the assumption that the data path had no need to read the qdisc qlen (number of packets in the qdisc). It is true when pfifo_fast is used as the root qdisc, or as direct MQ/MQPRIO children. But pfifo_fast can be used as