On 2/4/2021 4:47 PM, Ido Schimmel wrote:
On Wed, Feb 03, 2021 at 06:21:03PM -0800, Jakub Kicinski wrote:
On Wed, 3 Feb 2021 11:10:28 +0800 Chris Mi wrote:
Currently, the netlink skb length only includes metadata and data
length. It doesn't include the psample generic netlink header length.
Bu
On 2/4/2021 10:21 AM, Jakub Kicinski wrote:
On Wed, 3 Feb 2021 11:10:28 +0800 Chris Mi wrote:
Currently, the netlink skb length only includes metadata and data
length. It doesn't include the psample generic netlink header length.
But what's the bug? Did you see oversized messages on the socket
On Wed, Feb 03, 2021 at 06:21:03PM -0800, Jakub Kicinski wrote:
> On Wed, 3 Feb 2021 11:10:28 +0800 Chris Mi wrote:
> > Currently, the netlink skb length only includes metadata and data
> > length. It doesn't include the psample generic netlink header length.
>
> But what's the bug? Did you see o
On Wed, 3 Feb 2021 11:10:28 +0800 Chris Mi wrote:
> Currently, the netlink skb length only includes metadata and data
> length. It doesn't include the psample generic netlink header length.
But what's the bug? Did you see oversized messages on the socket? Did
one of the nla_put() fail?
> Fixes:
Currently, the netlink skb length only includes metadata and data
length. It doesn't include the psample generic netlink header length.
Fix it by adding it.
Fixes: 6ae0a6286171 ("net: Introduce psample, a new genetlink channel for
packet sampling")
CC: Yotam Gigi
Reviewed-by: Ido Schimmel
Signe
