RE: [PATCH net] net: poll tx timeout only on active tx queues

2016-07-05 Thread Yuval Mintz
> >> > currently all the device driver call > >> > netif_tx_start_all_queues(dev) on open to W/A this issue. which is > >> > strange since only real_num_tx_queues are active. > >> > >> You could also argue that netif_tx_start_all_queues() should only > >> enable the real_num_tx_queues. > >> [Althou

Re: [PATCH net] net: poll tx timeout only on active tx queues

2016-07-01 Thread Saeed Mahameed
On Fri, Jul 1, 2016 at 8:18 AM, Eric Dumazet wrote: > On Fri, 2016-07-01 at 04:50 +, Yuval Mintz wrote: >> > currently all the device driver call netif_tx_start_all_queues(dev) >> > on open to W/A this issue. which is strange since only >> > real_num_tx_queues are active. >> >> You could also

Re: [PATCH net] net: poll tx timeout only on active tx queues

2016-06-30 Thread Eric Dumazet
On Fri, 2016-07-01 at 04:50 +, Yuval Mintz wrote: > > currently all the device driver call netif_tx_start_all_queues(dev) > > on open to W/A this issue. which is strange since only > > real_num_tx_queues are active. > > You could also argue that netif_tx_start_all_queues() should > only enabl

Re: [PATCH net] net: poll tx timeout only on active tx queues

2016-06-30 Thread Yuval Mintz
> currently all the device driver callĀ  netif_tx_start_all_queues(dev) > on open to W/A this issue. which is strange since only > real_num_tx_queues are active. You could also argue that netif_tx_start_all_queues() should only enable the real_num_tx_queues. [Although that would obviously cause all

Re: [PATCH net] net: poll tx timeout only on active tx queues

2016-06-30 Thread Saeed Mahameed
On Thu, Jun 30, 2016 at 5:28 PM, Eric Dumazet wrote: > On Thu, 2016-06-30 at 16:58 +0300, Saeed Mahameed wrote: >> - for (i = 0; i < dev->num_tx_queues; i++) { >> + for (i = 0; i < dev->real_num_tx_queues; i++) { >> struct netde

Re: [PATCH net] net: poll tx timeout only on active tx queues

2016-06-30 Thread Eric Dumazet
On Thu, 2016-06-30 at 16:58 +0300, Saeed Mahameed wrote: > From: Mohamad Haj Yahia > > Change the netdev watchdog to poll only the real active tx queues > instead of polling all tx queues. > The netdev driver doesn't necessarily have to start/stop all the > tx queues including the inactive tx que

[PATCH net] net: poll tx timeout only on active tx queues

2016-06-30 Thread Saeed Mahameed
From: Mohamad Haj Yahia Change the netdev watchdog to poll only the real active tx queues instead of polling all tx queues. The netdev driver doesn't necessarily have to start/stop all the tx queues including the inactive tx queues. Fixes: fd2ea0a79faa ('net: Use queue aware tests throughout.')