Re: [PATCH net] net: phy: fix too strict check in phy_start_aneg

2019-01-15 Thread David Miller
From: Heiner Kallweit Date: Wed, 9 Jan 2019 20:34:56 +0100 > When adding checks to detect wrong usage of the phylib API we added > a check to phy_start_aneg() which is too strict. If the phylib > state machine is in state PHY_HALTED we should allow reconfiguring > and restarting aneg, and just do

Re: [PATCH net] net: phy: fix too strict check in phy_start_aneg

2019-01-12 Thread Florian Fainelli
On January 9, 2019 11:34:56 AM PST, Heiner Kallweit wrote: >When adding checks to detect wrong usage of the phylib API we added >a check to phy_start_aneg() which is too strict. If the phylib >state machine is in state PHY_HALTED we should allow reconfiguring >and restarting aneg, and just don

Re: [PATCH net] net: phy: fix too strict check in phy_start_aneg

2019-01-09 Thread Chris Wilson
Quoting Heiner Kallweit (2019-01-09 19:34:56) > When adding checks to detect wrong usage of the phylib API we added > a check to phy_start_aneg() which is too strict. If the phylib > state machine is in state PHY_HALTED we should allow reconfiguring > and restarting aneg, and just don't touch the s

[PATCH net] net: phy: fix too strict check in phy_start_aneg

2019-01-09 Thread Heiner Kallweit
When adding checks to detect wrong usage of the phylib API we added a check to phy_start_aneg() which is too strict. If the phylib state machine is in state PHY_HALTED we should allow reconfiguring and restarting aneg, and just don't touch the state. Fixes: 2b3e88ea6528 ("net: phy: improve phy sta