Re: [PATCH net] net: phy: fix resume handling

2017-12-13 Thread David Miller
From: Russell King Date: Tue, 12 Dec 2017 10:45:36 + > When a PHY has the BMCR_PDOWN bit set, it may decide to ignore writes > to other registers, or reset the registers to power-on defaults. > Micrel PHYs do this for their interrupt registers. > > The current structure of phylib tries to en

Re: [PATCH net] net: phy: fix resume handling

2017-12-13 Thread Andrew Lunn
On Tue, Dec 12, 2017 at 10:45:36AM +, Russell King wrote: > When a PHY has the BMCR_PDOWN bit set, it may decide to ignore writes > to other registers, or reset the registers to power-on defaults. > Micrel PHYs do this for their interrupt registers. > > The current structure of phylib tries to

[PATCH net] net: phy: fix resume handling

2017-12-12 Thread Russell King
When a PHY has the BMCR_PDOWN bit set, it may decide to ignore writes to other registers, or reset the registers to power-on defaults. Micrel PHYs do this for their interrupt registers. The current structure of phylib tries to enable interrupts before resuming (and releasing) the BMCR_PDOWN bit.