Re: [PATCH net] net: phy: fix phy_start to consider PHY_IGNORE_INTERRUPT

2018-02-07 Thread Heiner Kallweit
Am 07.02.2018 um 20:34 schrieb Florian Fainelli: > > > On 02/07/2018 11:26 AM, Heiner Kallweit wrote: >> Am 07.02.2018 um 20:06 schrieb Florian Fainelli: >>> >>> >>> On 02/07/2018 10:44 AM, Heiner Kallweit wrote: This condition wasn't adjusted when PHY_IGNORE_INTERRUPT (-2) was added lo

Re: [PATCH net] net: phy: fix phy_start to consider PHY_IGNORE_INTERRUPT

2018-02-07 Thread Florian Fainelli
On 02/07/2018 11:26 AM, Heiner Kallweit wrote: > Am 07.02.2018 um 20:06 schrieb Florian Fainelli: >> >> >> On 02/07/2018 10:44 AM, Heiner Kallweit wrote: >>> This condition wasn't adjusted when PHY_IGNORE_INTERRUPT (-2) was added >>> long ago. In case of PHY_IGNORE_INTERRUPT the MAC interrupt ind

Re: [PATCH net] net: phy: fix phy_start to consider PHY_IGNORE_INTERRUPT

2018-02-07 Thread Heiner Kallweit
Am 07.02.2018 um 20:06 schrieb Florian Fainelli: > > > On 02/07/2018 10:44 AM, Heiner Kallweit wrote: >> This condition wasn't adjusted when PHY_IGNORE_INTERRUPT (-2) was added >> long ago. In case of PHY_IGNORE_INTERRUPT the MAC interrupt indicates >> also PHY state changes and we should do what

Re: [PATCH net] net: phy: fix phy_start to consider PHY_IGNORE_INTERRUPT

2018-02-07 Thread Florian Fainelli
On 02/07/2018 10:44 AM, Heiner Kallweit wrote: > This condition wasn't adjusted when PHY_IGNORE_INTERRUPT (-2) was added > long ago. In case of PHY_IGNORE_INTERRUPT the MAC interrupt indicates > also PHY state changes and we should do what the symbol says. Do you use phy_enable_interrupts() to c

[PATCH net] net: phy: fix phy_start to consider PHY_IGNORE_INTERRUPT

2018-02-07 Thread Heiner Kallweit
This condition wasn't adjusted when PHY_IGNORE_INTERRUPT (-2) was added long ago. In case of PHY_IGNORE_INTERRUPT the MAC interrupt indicates also PHY state changes and we should do what the symbol says. Signed-off-by: Heiner Kallweit --- drivers/net/phy/phy.c | 2 +- 1 file changed, 1 insertion