Re: [PATCH net] net: phy: ensure PHY is powered up when reading ID registers

2019-01-07 Thread David Miller
From: Heiner Kallweit Date: Sat, 5 Jan 2019 14:21:03 +0100 > During a bug analysis we came across the fact that there's no guarantee > that reading from the ID registers returns a valid value if PHY is > powered down. When reading invalid values we may load no or the wrong > PHY driver. Therefore

Re: [PATCH net] net: phy: ensure PHY is powered up when reading ID registers

2019-01-06 Thread Heiner Kallweit
On 06.01.2019 01:12, Florian Fainelli wrote: > > > On January 5, 2019 5:21:03 AM PST, Heiner Kallweit > wrote: >> During a bug analysis we came across the fact that there's no guarantee >> that reading from the ID registers returns a valid value if PHY is >> powered down. When reading invalid v

Re: [PATCH net] net: phy: ensure PHY is powered up when reading ID registers

2019-01-05 Thread Florian Fainelli
On January 5, 2019 5:21:03 AM PST, Heiner Kallweit wrote: >During a bug analysis we came across the fact that there's no guarantee >that reading from the ID registers returns a valid value if PHY is >powered down. When reading invalid values we may load no or the wrong >PHY driver. Therefore le

Re: [PATCH net] net: phy: ensure PHY is powered up when reading ID registers

2019-01-05 Thread David Miller
From: Andrew Lunn Date: Sat, 5 Jan 2019 23:04:12 +0100 > I tend to be more paranoid after listening to recent discussions about > this. At LPC and online, there have been comments that patches to > stable are more likely to break something than patches going via the > normal merge window. Normal

Re: [PATCH net] net: phy: ensure PHY is powered up when reading ID registers

2019-01-05 Thread Andrew Lunn
> Quite a few of the latest net commits don't meet the strict criteria > for a fix (as documented). Means: The risk that a problem could > occur isn't sufficient, at least one user has to actually face a > problem. So it seems net vs. net-next criteria is somewhat flexible. > Therefore I wasn't sur

Re: [PATCH net] net: phy: ensure PHY is powered up when reading ID registers

2019-01-05 Thread David Miller
From: Heiner Kallweit Date: Sat, 5 Jan 2019 22:07:50 +0100 > Regarding net vs. net-next: > Quite a few of the latest net commits don't meet the strict criteria > for a fix (as documented). Means: The risk that a problem could > occur isn't sufficient, at least one user has to actually face a > pr

Re: [PATCH net] net: phy: ensure PHY is powered up when reading ID registers

2019-01-05 Thread Heiner Kallweit
On 05.01.2019 18:33, Andrew Lunn wrote: > On Sat, Jan 05, 2019 at 02:21:03PM +0100, Heiner Kallweit wrote: >> During a bug analysis we came across the fact that there's no guarantee >> that reading from the ID registers returns a valid value if PHY is >> powered down. When reading invalid values we

Re: [PATCH net] net: phy: ensure PHY is powered up when reading ID registers

2019-01-05 Thread Andrew Lunn
On Sat, Jan 05, 2019 at 02:21:03PM +0100, Heiner Kallweit wrote: > During a bug analysis we came across the fact that there's no guarantee > that reading from the ID registers returns a valid value if PHY is > powered down. When reading invalid values we may load no or the wrong > PHY driver. There

Re: [PATCH net] net: phy: ensure PHY is powered up when reading ID registers

2019-01-05 Thread Heiner Kallweit
On 05.01.2019 14:21, Heiner Kallweit wrote: > During a bug analysis we came across the fact that there's no guarantee > that reading from the ID registers returns a valid value if PHY is > powered down. When reading invalid values we may load no or the wrong > PHY driver. Therefore let's play safe

[PATCH net] net: phy: ensure PHY is powered up when reading ID registers

2019-01-05 Thread Heiner Kallweit
During a bug analysis we came across the fact that there's no guarantee that reading from the ID registers returns a valid value if PHY is powered down. When reading invalid values we may load no or the wrong PHY driver. Therefore let's play safe and power up the PHY before reading the ID registers