Re: [PATCH net] net: phy: Fix the issue that netif always links up after resuming

2018-12-18 Thread David Miller
From: Kunihiko Hayashi Date: Tue, 18 Dec 2018 16:57:04 +0900 > Even though the link is down before entering hibernation, > there is an issue that the network interface always links up after resuming > from hibernation. > > If the link is still down before enabling the network interface, > and af

Re: [PATCH net] net: phy: Fix the issue that netif always links up after resuming

2018-12-18 Thread Kunihiko Hayashi
Hi Heiner, On Tue, 18 Dec 2018 19:15:39 +0100 wrote: > On 18.12.2018 08:57, Kunihiko Hayashi wrote: > > Even though the link is down before entering hibernation, > > there is an issue that the network interface always links up after resuming > > from hibernation. > > > > If the link is still do

Re: [PATCH net] net: phy: Fix the issue that netif always links up after resuming

2018-12-18 Thread Heiner Kallweit
On 18.12.2018 08:57, Kunihiko Hayashi wrote: > Even though the link is down before entering hibernation, > there is an issue that the network interface always links up after resuming > from hibernation. > > If the link is still down before enabling the network interface, > and after resuming from

[PATCH net] net: phy: Fix the issue that netif always links up after resuming

2018-12-17 Thread Kunihiko Hayashi
Even though the link is down before entering hibernation, there is an issue that the network interface always links up after resuming from hibernation. If the link is still down before enabling the network interface, and after resuming from hibernation, the phydev->state is forcibly set to PHY_UP

Re: [RFC PATCH net] net: phy: fix the issue that netif always links up after resuming

2018-11-29 Thread Kunihiko Hayashi
Hi Heiner, On Fri, 30 Nov 2018 07:20:27 +0100 wrote: > On 30.11.2018 05:37, Kunihiko Hayashi wrote: > > Hi Heiner Florian, > > > > Thank you for your comments. > > > > On Thu, 29 Nov 2018 16:37:48 -0800 wrote: > > > >> > >> > >> On 11/29/2018 2:47 PM, Heiner Kallweit wrote: > >>> On 29.11.20

Re: [RFC PATCH net] net: phy: fix the issue that netif always links up after resuming

2018-11-29 Thread Heiner Kallweit
On 30.11.2018 05:37, Kunihiko Hayashi wrote: > Hi Heiner Florian, > > Thank you for your comments. > > On Thu, 29 Nov 2018 16:37:48 -0800 wrote: > >> >> >> On 11/29/2018 2:47 PM, Heiner Kallweit wrote: >>> On 29.11.2018 09:12, Kunihiko Hayashi wrote: Even though the link is down before ent

Re: [RFC PATCH net] net: phy: fix the issue that netif always links up after resuming

2018-11-29 Thread Kunihiko Hayashi
Hi Heiner Florian, Thank you for your comments. On Thu, 29 Nov 2018 16:37:48 -0800 wrote: > > > On 11/29/2018 2:47 PM, Heiner Kallweit wrote: > > On 29.11.2018 09:12, Kunihiko Hayashi wrote: > >> Even though the link is down before entering hibernation, > >> there is an issue that the network

Re: [RFC PATCH net] net: phy: fix the issue that netif always links up after resuming

2018-11-29 Thread Florian Fainelli
On 11/29/2018 2:47 PM, Heiner Kallweit wrote: > On 29.11.2018 09:12, Kunihiko Hayashi wrote: >> Even though the link is down before entering hibernation, >> there is an issue that the network interface always links up after resuming >> from hibernation. >> >> The phydev->state is PHY_READY befor

Re: [RFC PATCH net] net: phy: fix the issue that netif always links up after resuming

2018-11-29 Thread Heiner Kallweit
On 29.11.2018 09:12, Kunihiko Hayashi wrote: > Even though the link is down before entering hibernation, > there is an issue that the network interface always links up after resuming > from hibernation. > > The phydev->state is PHY_READY before enabling the network interface, so > the link is down

[RFC PATCH net] net: phy: fix the issue that netif always links up after resuming

2018-11-29 Thread Kunihiko Hayashi
Even though the link is down before entering hibernation, there is an issue that the network interface always links up after resuming from hibernation. The phydev->state is PHY_READY before enabling the network interface, so the link is down. After resuming from hibernation, the phydev->state is f