Re: [PATCH net] net: ipv4: Multipath needs to handle unreachable nexthops

2016-03-29 Thread David Ahern
On 3/25/16 4:05 AM, Julian Anastasov wrote: Hello, On Thu, 24 Mar 2016, David Ahern wrote: On 3/24/16 4:33 PM, Julian Anastasov wrote: But for multipath routes we can also consider the nexthops as "alternatives", so it depends on how one uses the multipath mechanism. The abil

Re: [PATCH net] net: ipv4: Multipath needs to handle unreachable nexthops

2016-03-25 Thread Julian Anastasov
Hello, On Thu, 24 Mar 2016, David Ahern wrote: > On 3/24/16 4:33 PM, Julian Anastasov wrote: > > But for multipath routes we can also consider the > > nexthops as "alternatives", so it depends on how one uses > > the multipath mechanism. The ability to fallback to > > another nexthop

Re: [PATCH net] net: ipv4: Multipath needs to handle unreachable nexthops

2016-03-24 Thread David Ahern
On 3/24/16 4:33 PM, Julian Anastasov wrote: But for multipath routes we can also consider the nexthops as "alternatives", so it depends on how one uses the multipath mechanism. The ability to fallback to another nexthop assumes one connection is allowed to move from one ISP to another. Wh

Re: [PATCH net] net: ipv4: Multipath needs to handle unreachable nexthops

2016-03-24 Thread Julian Anastasov
Hello, On Thu, 24 Mar 2016, David Ahern wrote: > Multipath route lookups should consider knowledge about next hops and not > select a hop that is known to be failed. ... > The failed path can be avoided by considering known neighbor information > when selecting next hops. If the neighb

Re: [PATCH net] net: ipv4: Multipath needs to handle unreachable nexthops

2016-03-24 Thread David Miller
From: Eric Dumazet Date: Thu, 24 Mar 2016 09:45:34 -0700 > On Thu, 2016-03-24 at 08:25 -0700, David Ahern wrote: >> Multipath route lookups should consider knowledge about next hops and not >> select a hop that is known to be failed. > > Does not look a net candidate to me. > >> Signed-off-by:

Re: [PATCH net] net: ipv4: Multipath needs to handle unreachable nexthops

2016-03-24 Thread Eric Dumazet
On Thu, 2016-03-24 at 11:43 -0600, David Ahern wrote: > On 3/24/16 10:45 AM, Eric Dumazet wrote: > > On Thu, 2016-03-24 at 08:25 -0700, David Ahern wrote: > >> Multipath route lookups should consider knowledge about next hops and not > >> select a hop that is known to be failed. > > > > Does not lo

Re: [PATCH net] net: ipv4: Multipath needs to handle unreachable nexthops

2016-03-24 Thread David Ahern
On 3/24/16 10:45 AM, Eric Dumazet wrote: On Thu, 2016-03-24 at 08:25 -0700, David Ahern wrote: Multipath route lookups should consider knowledge about next hops and not select a hop that is known to be failed. Does not look a net candidate to me. you don't consider this a bug? certainly not

Re: [PATCH net] net: ipv4: Multipath needs to handle unreachable nexthops

2016-03-24 Thread Eric Dumazet
On Thu, 2016-03-24 at 08:25 -0700, David Ahern wrote: > Multipath route lookups should consider knowledge about next hops and not > select a hop that is known to be failed. Does not look a net candidate to me. > Signed-off-by: David Ahern > --- > net/ipv4/fib_semantics.c | 34 ++

[PATCH net] net: ipv4: Multipath needs to handle unreachable nexthops

2016-03-24 Thread David Ahern
Multipath route lookups should consider knowledge about next hops and not select a hop that is known to be failed. Example: [h2] [h3] 15.0.0.5 | | 3| 3| [SP1]