Re: [PATCH net] net: ipa: pass correct dma_handle to dma_free_coherent()

2021-02-02 Thread Jakub Kicinski
On Tue, 2 Feb 2021 05:48:11 -0600 Alex Elder wrote: > On 2/1/21 11:55 PM, Dan Carpenter wrote: > > The "ring->addr = addr;" assignment is done a few lines later so we > > can't use "ring->addr" yet. The correct dma_handle is "addr". > > > > Fixes: 650d1603825d ("soc: qcom: ipa: the generic softwa

Re: [PATCH net] net: ipa: pass correct dma_handle to dma_free_coherent()

2021-02-02 Thread Alex Elder
On 2/1/21 11:55 PM, Dan Carpenter wrote: > The "ring->addr = addr;" assignment is done a few lines later so we > can't use "ring->addr" yet. The correct dma_handle is "addr". > > Fixes: 650d1603825d ("soc: qcom: ipa: the generic software interface") > Signed-off-by: Dan Carpenter Yikes. Thank

[PATCH net] net: ipa: pass correct dma_handle to dma_free_coherent()

2021-02-01 Thread Dan Carpenter
The "ring->addr = addr;" assignment is done a few lines later so we can't use "ring->addr" yet. The correct dma_handle is "addr". Fixes: 650d1603825d ("soc: qcom: ipa: the generic software interface") Signed-off-by: Dan Carpenter --- Smatch also complians about: drivers/net/ipa/gsi.c:1739 g