Re: [PATCH net] net: flow_offload: Fix memory leak for indirect flow block

2020-12-07 Thread Chris Mi
On 12/8/2020 10:28 AM, Jakub Kicinski wrote: On Mon, 7 Dec 2020 09:59:16 +0800 Chris Mi wrote: The offending commit introduces a cleanup callback that is invoked when the driver module is removed to clean up the tunnel device flow block. But it returns on the first iteration of the for loop. Th

Re: [PATCH net] net: flow_offload: Fix memory leak for indirect flow block

2020-12-07 Thread Jakub Kicinski
On Mon, 7 Dec 2020 09:59:16 +0800 Chris Mi wrote: > The offending commit introduces a cleanup callback that is invoked > when the driver module is removed to clean up the tunnel device > flow block. But it returns on the first iteration of the for loop. > The remaining indirect flow blocks will ne

[PATCH net] net: flow_offload: Fix memory leak for indirect flow block

2020-12-06 Thread Chris Mi
The offending commit introduces a cleanup callback that is invoked when the driver module is removed to clean up the tunnel device flow block. But it returns on the first iteration of the for loop. The remaining indirect flow blocks will never be freed. Fixes: 1fac52da5942 ("net: flow_offload: con