Re: [PATCH net] net: fix feature changes on devices without ndo_set_features

2015-11-18 Thread Sergei Shtylyov
Hello. On 11/18/2015 2:10 AM, Nikolay Aleksandrov wrote: From: Nikolay Aleksandrov When __netdev_update_features() was updated to ensure some features are disabled on new lower devices, an error was introduced for devices which don't have the ndo_set_features() method set. Before we'll just s

Re: [PATCH net] net: fix feature changes on devices without ndo_set_features

2015-11-17 Thread Nikolay Aleksandrov
On 11/18/2015 12:03 AM, Sergei Shtylyov wrote: > Hello. > > On 11/13/2015 04:54 PM, Nikolay Aleksandrov wrote: > >> From: Nikolay Aleksandrov >> >> When __netdev_update_features() was updated to ensure some features are >> disabled on new lower devices, an error was introduced for devices which

Re: [PATCH net] net: fix feature changes on devices without ndo_set_features

2015-11-17 Thread Sergei Shtylyov
Hello. On 11/13/2015 04:54 PM, Nikolay Aleksandrov wrote: From: Nikolay Aleksandrov When __netdev_update_features() was updated to ensure some features are disabled on new lower devices, an error was introduced for devices which don't have the ndo_set_features() method set. Before we'll just

Re: [PATCH net] net: fix feature changes on devices without ndo_set_features

2015-11-16 Thread David Miller
From: Nikolay Aleksandrov Date: Fri, 13 Nov 2015 14:54:01 +0100 > From: Nikolay Aleksandrov > > When __netdev_update_features() was updated to ensure some features are > disabled on new lower devices, an error was introduced for devices which > don't have the ndo_set_features() method set. Befo

Re: [PATCH net] net: fix feature changes on devices without ndo_set_features

2015-11-13 Thread Florian Fainelli
On 13/11/15 05:54, Nikolay Aleksandrov wrote: > From: Nikolay Aleksandrov > > When __netdev_update_features() was updated to ensure some features are > disabled on new lower devices, an error was introduced for devices which > don't have the ndo_set_features() method set. Before we'll just set th

Re: [PATCH net] net: fix feature changes on devices without ndo_set_features

2015-11-13 Thread Jarod Wilson
Nikolay Aleksandrov wrote: From: Nikolay Aleksandrov When __netdev_update_features() was updated to ensure some features are disabled on new lower devices, an error was introduced for devices which don't have the ndo_set_features() method set. Before we'll just set the new features, but now we r

Re: [PATCH net] net: fix feature changes on devices without ndo_set_features

2015-11-13 Thread Andy Gospodarek
On Fri, Nov 13, 2015 at 02:54:01PM +0100, Nikolay Aleksandrov wrote: > From: Nikolay Aleksandrov > > When __netdev_update_features() was updated to ensure some features are > disabled on new lower devices, an error was introduced for devices which > don't have the ndo_set_features() method set. B

Re: [PATCH net] net: fix feature changes on devices without ndo_set_features

2015-11-13 Thread Jiri Pirko
Fri, Nov 13, 2015 at 02:54:01PM CET, ra...@blackwall.org wrote: >From: Nikolay Aleksandrov > >When __netdev_update_features() was updated to ensure some features are >disabled on new lower devices, an error was introduced for devices which >don't have the ndo_set_features() method set. Before we'l

[PATCH net] net: fix feature changes on devices without ndo_set_features

2015-11-13 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov When __netdev_update_features() was updated to ensure some features are disabled on new lower devices, an error was introduced for devices which don't have the ndo_set_features() method set. Before we'll just set the new features, but now we return an error and don't set