Re: [PATCH net] net: enforce xmit_recursion for devices with a queue

2019-04-10 Thread Sabrina Dubroca
Hi Eric, 2019-03-14, 10:51:49 -0700, Eric Dumazet wrote: > On 03/14/2019 10:40 AM, Sabrina Dubroca wrote: > > 2019-03-14, 07:56:10 -0700, Eric Dumazet wrote: > >> On 03/14/2019 07:15 AM, Sabrina Dubroca wrote: > >>> 2019-03-14, 05:58:03 -0700, Eric Dumazet wrote: > On 03/14/2019 03:15 AM, Sab

Re: [PATCH net] net: enforce xmit_recursion for devices with a queue

2019-03-14 Thread Sabrina Dubroca
2019-03-14, 10:51:49 -0700, Eric Dumazet wrote: > > > On 03/14/2019 10:40 AM, Sabrina Dubroca wrote: > > 2019-03-14, 07:56:10 -0700, Eric Dumazet wrote: > >> > >> > >> On 03/14/2019 07:15 AM, Sabrina Dubroca wrote: > >>> 2019-03-14, 05:58:03 -0700, Eric Dumazet wrote: > > > On 03/1

Re: [PATCH net] net: enforce xmit_recursion for devices with a queue

2019-03-14 Thread Eric Dumazet
On 03/14/2019 10:40 AM, Sabrina Dubroca wrote: > 2019-03-14, 07:56:10 -0700, Eric Dumazet wrote: >> >> >> On 03/14/2019 07:15 AM, Sabrina Dubroca wrote: >>> 2019-03-14, 05:58:03 -0700, Eric Dumazet wrote: On 03/14/2019 03:15 AM, Sabrina Dubroca wrote: > Commit 745e20f1b626 ("n

Re: [PATCH net] net: enforce xmit_recursion for devices with a queue

2019-03-14 Thread Sabrina Dubroca
2019-03-14, 07:56:10 -0700, Eric Dumazet wrote: > > > On 03/14/2019 07:15 AM, Sabrina Dubroca wrote: > > 2019-03-14, 05:58:03 -0700, Eric Dumazet wrote: > >> > >> > >> On 03/14/2019 03:15 AM, Sabrina Dubroca wrote: > >>> Commit 745e20f1b626 ("net: add a recursion limit in xmit path") > >>> introd

Re: [PATCH net] net: enforce xmit_recursion for devices with a queue

2019-03-14 Thread Eric Dumazet
On 03/14/2019 07:15 AM, Sabrina Dubroca wrote: > 2019-03-14, 05:58:03 -0700, Eric Dumazet wrote: >> >> >> On 03/14/2019 03:15 AM, Sabrina Dubroca wrote: >>> Commit 745e20f1b626 ("net: add a recursion limit in xmit path") >>> introduced a recursion limit, but it only applies to devices without a

Re: [PATCH net] net: enforce xmit_recursion for devices with a queue

2019-03-14 Thread Sabrina Dubroca
2019-03-14, 05:58:03 -0700, Eric Dumazet wrote: > > > On 03/14/2019 03:15 AM, Sabrina Dubroca wrote: > > Commit 745e20f1b626 ("net: add a recursion limit in xmit path") > > introduced a recursion limit, but it only applies to devices without a > > queue. Virtual devices with a queue (either becau

Re: [PATCH net] net: enforce xmit_recursion for devices with a queue

2019-03-14 Thread Eric Dumazet
On 03/14/2019 03:15 AM, Sabrina Dubroca wrote: > Commit 745e20f1b626 ("net: add a recursion limit in xmit path") > introduced a recursion limit, but it only applies to devices without a > queue. Virtual devices with a queue (either because they don't have > the IFF_NO_QUEUE flag, or because the

[PATCH net] net: enforce xmit_recursion for devices with a queue

2019-03-14 Thread Sabrina Dubroca
Commit 745e20f1b626 ("net: add a recursion limit in xmit path") introduced a recursion limit, but it only applies to devices without a queue. Virtual devices with a queue (either because they don't have the IFF_NO_QUEUE flag, or because the administrator added one) can still cause an unbounded recu