Re: [PATCH net] net: dsa: mv88e6xxx: fix few issues in mv88e6390x_port_set_cmode

2019-03-27 Thread David Miller
From: Heiner Kallweit Date: Sat, 23 Mar 2019 19:41:32 +0100 > This patches fixes few issues in mv88e6390x_port_set_cmode(). > > 1. When entering the function the old cmode may be 0, in this case >mv88e6390x_serdes_get_lane() returns -ENODEV. As result we bail >out and have no chance to s

Re: [PATCH net] net: dsa: mv88e6xxx: fix few issues in mv88e6390x_port_set_cmode

2019-03-27 Thread Heiner Kallweit
On 27.03.2019 22:22, Florian Fainelli wrote: > On 3/23/19 11:41 AM, Heiner Kallweit wrote: >> This patches fixes few issues in mv88e6390x_port_set_cmode(). >> >> 1. When entering the function the old cmode may be 0, in this case >>mv88e6390x_serdes_get_lane() returns -ENODEV. As result we bail

Re: [PATCH net] net: dsa: mv88e6xxx: fix few issues in mv88e6390x_port_set_cmode

2019-03-27 Thread Florian Fainelli
On 3/23/19 11:41 AM, Heiner Kallweit wrote: > This patches fixes few issues in mv88e6390x_port_set_cmode(). > > 1. When entering the function the old cmode may be 0, in this case >mv88e6390x_serdes_get_lane() returns -ENODEV. As result we bail >out and have no chance to set a new mode. The

Re: [PATCH net] net: dsa: mv88e6xxx: fix few issues in mv88e6390x_port_set_cmode

2019-03-27 Thread David Miller
From: Heiner Kallweit Date: Sat, 23 Mar 2019 19:41:32 +0100 > This patches fixes few issues in mv88e6390x_port_set_cmode(). > > 1. When entering the function the old cmode may be 0, in this case >mv88e6390x_serdes_get_lane() returns -ENODEV. As result we bail >out and have no chance to s

Re: [PATCH net] net: dsa: mv88e6xxx: fix few issues in mv88e6390x_port_set_cmode

2019-03-26 Thread David Miller
From: Heiner Kallweit Date: Sat, 23 Mar 2019 19:41:32 +0100 > This patches fixes few issues in mv88e6390x_port_set_cmode(). > > 1. When entering the function the old cmode may be 0, in this case >mv88e6390x_serdes_get_lane() returns -ENODEV. As result we bail >out and have no chance to s

[PATCH net] net: dsa: mv88e6xxx: fix few issues in mv88e6390x_port_set_cmode

2019-03-23 Thread Heiner Kallweit
This patches fixes few issues in mv88e6390x_port_set_cmode(). 1. When entering the function the old cmode may be 0, in this case mv88e6390x_serdes_get_lane() returns -ENODEV. As result we bail out and have no chance to set a new mode. Therefore deal properly with -ENODEV. 2. Once we have