Re: [PATCH net] net: dsa: mv88e6xxx: do not allow inband AN for 2500base-x mode

2021-01-15 Thread Andrew Lunn
On Fri, Jan 15, 2021 at 12:55:16AM +0100, Marek Behún wrote: > On Fri, 15 Jan 2021 00:00:33 +0100 > Andrew Lunn wrote: > > > > diff --git a/drivers/net/dsa/mv88e6xxx/serdes.c > > > b/drivers/net/dsa/mv88e6xxx/serdes.c > > > index 3195936dc5be..b8241820679e 100644 > > > --- a/drivers/net/dsa/mv88

Re: [PATCH net] net: dsa: mv88e6xxx: do not allow inband AN for 2500base-x mode

2021-01-14 Thread Marek Behún
On Fri, 15 Jan 2021 00:00:33 +0100 Andrew Lunn wrote: > > diff --git a/drivers/net/dsa/mv88e6xxx/serdes.c > > b/drivers/net/dsa/mv88e6xxx/serdes.c > > index 3195936dc5be..b8241820679e 100644 > > --- a/drivers/net/dsa/mv88e6xxx/serdes.c > > +++ b/drivers/net/dsa/mv88e6xxx/serdes.c > > @@ -55,9 +5

Re: [PATCH net] net: dsa: mv88e6xxx: do not allow inband AN for 2500base-x mode

2021-01-14 Thread Andrew Lunn
> diff --git a/drivers/net/dsa/mv88e6xxx/serdes.c > b/drivers/net/dsa/mv88e6xxx/serdes.c > index 3195936dc5be..b8241820679e 100644 > --- a/drivers/net/dsa/mv88e6xxx/serdes.c > +++ b/drivers/net/dsa/mv88e6xxx/serdes.c > @@ -55,9 +55,20 @@ static int mv88e6xxx_serdes_pcs_get_state(struct > mv88e6xx

[PATCH net] net: dsa: mv88e6xxx: do not allow inband AN for 2500base-x mode

2021-01-13 Thread Marek Behún
Commit a5a6858b793ff ("net: dsa: mv88e6xxx: extend phylink to Serdes PHYs") introduced method mv88e6390_serdes_pcs_config(), which is called (indirectly) by phylink to configure the PCS. This method enables inband AN if requested by phylink. It seems though that for 2500base-x mode some of these