Re: [PATCH net] net: dsa: bcm_sf2: Fix ageing conditions and operation

2015-09-08 Thread David Miller
From: Florian Fainelli Date: Sat, 5 Sep 2015 13:07:27 -0700 > The comparison check between cur_hw_state and hw_state is currently > invalid because cur_hw_state is right shifted by G_MISTP_SHIFT, while > hw_state is not, so we end-up comparing bits 2:0 with bits 7:5, which is > going to cause an

[PATCH net] net: dsa: bcm_sf2: Fix ageing conditions and operation

2015-09-05 Thread Florian Fainelli
The comparison check between cur_hw_state and hw_state is currently invalid because cur_hw_state is right shifted by G_MISTP_SHIFT, while hw_state is not, so we end-up comparing bits 2:0 with bits 7:5, which is going to cause an additional aging to occur. Fix this by not shifting cur_hw_state while