Re: [PATCH net] net: don't clear sock->sk early to avoid trouble in strparser

2019-05-30 Thread David Miller
From: Jakub Kicinski Date: Wed, 29 May 2019 16:33:23 -0700 > af_inet sets sock->sk to NULL which trips strparser over: ... > To avoid this issue set sock->sk after sk_prot->close. > My grepping and testing did not discover any code which > would depend on the current behaviour. > > Fixes: c4623

[PATCH net] net: don't clear sock->sk early to avoid trouble in strparser

2019-05-29 Thread Jakub Kicinski
af_inet sets sock->sk to NULL which trips strparser over: BUG: kernel NULL pointer dereference, address: 0012 PGD 0 P4D 0 Oops: [#1] SMP PTI CPU: 7 PID: 0 Comm: swapper/7 Not tainted 5.2.0-rc1-00139-g14629453a6d3 #21 RIP: 0010:tcp_peek_len+0x10/0x60 RSP: 0018:c02e41c54b98 EFLA