Re: [PATCH net] net: bridge: start hello timer only if device is up

2017-06-01 Thread Sebastian Ott
On Thu, 1 Jun 2017, Nikolay Aleksandrov wrote: > When the transition of NO_STP -> KERNEL_STP was fixed by always calling > mod_timer in br_stp_start, it introduced a new regression which causes > the timer to be armed even when the bridge is down, and since we stop > the timers in its ndo_stop() fu

Re: [PATCH net] net: bridge: start hello timer only if device is up

2017-06-01 Thread David Miller
From: Nikolay Aleksandrov Date: Thu, 1 Jun 2017 18:07:55 +0300 > When the transition of NO_STP -> KERNEL_STP was fixed by always calling > mod_timer in br_stp_start, it introduced a new regression which causes > the timer to be armed even when the bridge is down, and since we stop > the timers i

[PATCH net] net: bridge: start hello timer only if device is up

2017-06-01 Thread Nikolay Aleksandrov
When the transition of NO_STP -> KERNEL_STP was fixed by always calling mod_timer in br_stp_start, it introduced a new regression which causes the timer to be armed even when the bridge is down, and since we stop the timers in its ndo_stop() function, they never get disabled if the device is destro