Re: [PATCH net] net: bcmgenet: fix error returns in bcmgenet_probe()

2020-07-20 Thread Florian Fainelli
On 7/20/20 12:18 AM, Zhang Changzhong wrote: > The driver forgets to call clk_disable_unprepare() in error path after > a success calling for clk_prepare_enable(). > > Fix to goto err_clk_disable if clk_prepare_enable() is successful. > > Fixes: 99d55638d4b0 ("net: bcmgenet: enable NETIF_F_HIGHDM

Re: [PATCH net] net: bcmgenet: fix error returns in bcmgenet_probe()

2020-07-20 Thread Doug Berger
On 7/20/2020 12:18 AM, Zhang Changzhong wrote: > The driver forgets to call clk_disable_unprepare() in error path after > a success calling for clk_prepare_enable(). > > Fix to goto err_clk_disable if clk_prepare_enable() is successful. > > Fixes: 99d55638d4b0 ("net: bcmgenet: enable NETIF_F_HIGH

[PATCH net] net: bcmgenet: fix error returns in bcmgenet_probe()

2020-07-20 Thread Zhang Changzhong
The driver forgets to call clk_disable_unprepare() in error path after a success calling for clk_prepare_enable(). Fix to goto err_clk_disable if clk_prepare_enable() is successful. Fixes: c80d36ff63a5 ("net: bcmgenet: Use devm_clk_get_optional() to get the clocks") Signed-off-by: Zhang Changzho

[PATCH net] net: bcmgenet: fix error returns in bcmgenet_probe()

2020-07-20 Thread Zhang Changzhong
The driver forgets to call clk_disable_unprepare() in error path after a success calling for clk_prepare_enable(). Fix to goto err_clk_disable if clk_prepare_enable() is successful. Fixes: 99d55638d4b0 ("net: bcmgenet: enable NETIF_F_HIGHDMA flag") Signed-off-by: Zhang Changzhong --- drivers/ne