Re: [PATCH net] net: Handle negative checksum offset in skb-checksum-help

2015-09-21 Thread Pravin Shelar
On Mon, Sep 21, 2015 at 8:21 PM, Eric Dumazet wrote: > On Mon, 2015-09-21 at 19:49 -0700, Pravin Shelar wrote: >> On Mon, Sep 21, 2015 at 7:14 PM, Eric Dumazet wrote: >> > On Mon, 2015-09-21 at 18:04 -0700, Pravin Shelar wrote: >> >> On Mon, Sep 21, 2015 at 5:14 PM, David Miller wrote: >> >> > F

Re: [PATCH net] net: Handle negative checksum offset in skb-checksum-help

2015-09-21 Thread Eric Dumazet
On Mon, 2015-09-21 at 19:49 -0700, Pravin Shelar wrote: > On Mon, Sep 21, 2015 at 7:14 PM, Eric Dumazet wrote: > > On Mon, 2015-09-21 at 18:04 -0700, Pravin Shelar wrote: > >> On Mon, Sep 21, 2015 at 5:14 PM, David Miller wrote: > >> > From: Pravin B Shelar > >> > Date: Sun, 20 Sep 2015 23:53:17

Re: [PATCH net] net: Handle negative checksum offset in skb-checksum-help

2015-09-21 Thread Pravin Shelar
On Mon, Sep 21, 2015 at 7:14 PM, Eric Dumazet wrote: > On Mon, 2015-09-21 at 18:04 -0700, Pravin Shelar wrote: >> On Mon, Sep 21, 2015 at 5:14 PM, David Miller wrote: >> > From: Pravin B Shelar >> > Date: Sun, 20 Sep 2015 23:53:17 -0700 >> > >> >> VXLAN device can receive skb with checksum parti

Re: [PATCH net] net: Handle negative checksum offset in skb-checksum-help

2015-09-21 Thread Eric Dumazet
On Mon, 2015-09-21 at 18:04 -0700, Pravin Shelar wrote: > On Mon, Sep 21, 2015 at 5:14 PM, David Miller wrote: > > From: Pravin B Shelar > > Date: Sun, 20 Sep 2015 23:53:17 -0700 > > > >> VXLAN device can receive skb with checksum partial. But the checksum > >> offset could be in outer header whi

Re: [PATCH net] net: Handle negative checksum offset in skb-checksum-help

2015-09-21 Thread Pravin Shelar
On Mon, Sep 21, 2015 at 5:14 PM, David Miller wrote: > From: Pravin B Shelar > Date: Sun, 20 Sep 2015 23:53:17 -0700 > >> VXLAN device can receive skb with checksum partial. But the checksum >> offset could be in outer header which is pulled on receive. > > Such a scenerio is a bug. > > Anything

Re: [PATCH net] net: Handle negative checksum offset in skb-checksum-help

2015-09-21 Thread David Miller
From: Pravin B Shelar Date: Sun, 20 Sep 2015 23:53:17 -0700 > VXLAN device can receive skb with checksum partial. But the checksum > offset could be in outer header which is pulled on receive. Such a scenerio is a bug. Anything that pulls off a header should use a utility function such as skb_p

Re: [PATCH net] net: Handle negative checksum offset in skb-checksum-help

2015-09-21 Thread Pravin Shelar
On Mon, Sep 21, 2015 at 8:47 AM, Alexander Duyck wrote: > On 09/20/2015 11:53 PM, Pravin B Shelar wrote: >> >> VXLAN device can receive skb with checksum partial. But the checksum >> offset could be in outer header which is pulled on receive. This results >> in negative checksum offset for the skb

Re: [PATCH net] net: Handle negative checksum offset in skb-checksum-help

2015-09-21 Thread Alexander Duyck
On 09/20/2015 11:53 PM, Pravin B Shelar wrote: VXLAN device can receive skb with checksum partial. But the checksum offset could be in outer header which is pulled on receive. This results in negative checksum offset for the skb. Such skb can cause the assert failure in skb_checksum_help(). The p

[PATCH net] net: Handle negative checksum offset in skb-checksum-help

2015-09-20 Thread Pravin B Shelar
VXLAN device can receive skb with checksum partial. But the checksum offset could be in outer header which is pulled on receive. This results in negative checksum offset for the skb. Such skb can cause the assert failure in skb_checksum_help(). The patch fixes the bug by checking for negative offse