Re: [PATCH net] net: Fix gro aggregation for udp encaps with zero csum

2021-02-28 Thread Jakub Kicinski
On Sat, 27 Feb 2021 09:16:38 -0800 John Fastabend wrote: > Willem de Bruijn wrote: > > On Fri, Feb 26, 2021 at 4:23 PM Daniel Borkmann > > wrote: > > > > > > We noticed a GRO issue for UDP-based encaps such as vxlan/geneve when the > > > csum for the UDP header itself is 0. In that case, GRO ag

Re: [PATCH net] net: Fix gro aggregation for udp encaps with zero csum

2021-02-27 Thread John Fastabend
Willem de Bruijn wrote: > On Fri, Feb 26, 2021 at 4:23 PM Daniel Borkmann wrote: > > > > We noticed a GRO issue for UDP-based encaps such as vxlan/geneve when the > > csum for the UDP header itself is 0. In that case, GRO aggregation does > > not take place on the phys dev, but instead is deferred

Re: [PATCH net] net: Fix gro aggregation for udp encaps with zero csum

2021-02-27 Thread Willem de Bruijn
On Fri, Feb 26, 2021 at 4:23 PM Daniel Borkmann wrote: > > We noticed a GRO issue for UDP-based encaps such as vxlan/geneve when the > csum for the UDP header itself is 0. In that case, GRO aggregation does > not take place on the phys dev, but instead is deferred to the vxlan/geneve > driver (see

[PATCH net] net: Fix gro aggregation for udp encaps with zero csum

2021-02-26 Thread Daniel Borkmann
We noticed a GRO issue for UDP-based encaps such as vxlan/geneve when the csum for the UDP header itself is 0. In that case, GRO aggregation does not take place on the phys dev, but instead is deferred to the vxlan/geneve driver (see trace below). The reason is essentially that GRO aggregation bai