Re: [PATCH net] net/xdp: Fix suspicious RCU usage warning

2018-08-12 Thread Daniel Borkmann
On 08/12/2018 10:45 AM, Tariq Toukan wrote: > > > On 20/07/2018 12:36 AM, Alexei Starovoitov wrote: >> On Wed, Jul 18, 2018 at 05:13:54PM +0300, Tariq Toukan wrote: >>> >>> >>> On 17/07/2018 10:27 PM, Daniel Borkmann wrote: On 07/17/2018 06:47 PM, Alexei Starovoitov wrote: > On Tue, Jul

Re: [PATCH net] net/xdp: Fix suspicious RCU usage warning

2018-08-12 Thread Tariq Toukan
On 20/07/2018 12:36 AM, Alexei Starovoitov wrote: On Wed, Jul 18, 2018 at 05:13:54PM +0300, Tariq Toukan wrote: On 17/07/2018 10:27 PM, Daniel Borkmann wrote: On 07/17/2018 06:47 PM, Alexei Starovoitov wrote: On Tue, Jul 17, 2018 at 06:10:38PM +0300, Tariq Toukan wrote: Fix the warning b

Re: [PATCH net] net/xdp: Fix suspicious RCU usage warning

2018-07-19 Thread Alexei Starovoitov
On Wed, Jul 18, 2018 at 05:13:54PM +0300, Tariq Toukan wrote: > > > On 17/07/2018 10:27 PM, Daniel Borkmann wrote: > > On 07/17/2018 06:47 PM, Alexei Starovoitov wrote: > > > On Tue, Jul 17, 2018 at 06:10:38PM +0300, Tariq Toukan wrote: > > > > Fix the warning below by calling rhashtable_lookup u

Re: [PATCH net] net/xdp: Fix suspicious RCU usage warning

2018-07-18 Thread Tariq Toukan
On 17/07/2018 10:27 PM, Daniel Borkmann wrote: On 07/17/2018 06:47 PM, Alexei Starovoitov wrote: On Tue, Jul 17, 2018 at 06:10:38PM +0300, Tariq Toukan wrote: Fix the warning below by calling rhashtable_lookup under RCU read lock. ... mutex_lock(&mem_id_lock); + rcu_read_lock

Re: [PATCH net] net/xdp: Fix suspicious RCU usage warning

2018-07-17 Thread Daniel Borkmann
On 07/17/2018 06:47 PM, Alexei Starovoitov wrote: > On Tue, Jul 17, 2018 at 06:10:38PM +0300, Tariq Toukan wrote: >> Fix the warning below by calling rhashtable_lookup under >> RCU read lock. >> >> [ 342.450870] WARNING: suspicious RCU usage >> [ 342.455856] 4.18.0-rc2+ #17 Tainted: G O

Re: [PATCH net] net/xdp: Fix suspicious RCU usage warning

2018-07-17 Thread Alexei Starovoitov
On Tue, Jul 17, 2018 at 06:10:38PM +0300, Tariq Toukan wrote: > Fix the warning below by calling rhashtable_lookup under > RCU read lock. > > [ 342.450870] WARNING: suspicious RCU usage > [ 342.455856] 4.18.0-rc2+ #17 Tainted: G O > [ 342.462210] - > [ 342

[PATCH net] net/xdp: Fix suspicious RCU usage warning

2018-07-17 Thread Tariq Toukan
Fix the warning below by calling rhashtable_lookup under RCU read lock. [ 342.450870] WARNING: suspicious RCU usage [ 342.455856] 4.18.0-rc2+ #17 Tainted: G O [ 342.462210] - [ 342.467202] ./include/linux/rhashtable.h:481 suspicious rcu_dereference_check(