Re: [PATCH net] net/sched: act_tunnel_key: fix memory leak in case of action replace

2019-01-15 Thread David Miller
From: Davide Caratti Date: Thu, 10 Jan 2019 20:21:02 +0100 > running the following TDC test cases: > > 7afc - Replace tunnel_key set action with all parameters > 364d - Replace tunnel_key set action with all parameters and cookie > > it's possible to trigger kmemleak warnings like: ... > whe

Re: [PATCH net] net/sched: act_tunnel_key: fix memory leak in case of action replace

2019-01-11 Thread Cong Wang
On Thu, Jan 10, 2019 at 11:21 AM Davide Caratti wrote: > when the tunnel_key action is replaced, the kernel forgets to release the > dst metadata: ensure they are released by tunnel_key_init(), the same way > it's done in tunnel_key_release(). > > Fixes: d0f6dd8a914f4 ("net/sched: Introduce act_tu

[PATCH net] net/sched: act_tunnel_key: fix memory leak in case of action replace

2019-01-10 Thread Davide Caratti
running the following TDC test cases: 7afc - Replace tunnel_key set action with all parameters 364d - Replace tunnel_key set action with all parameters and cookie it's possible to trigger kmemleak warnings like: unreferenced object 0x94797127ab40 (size 192): comm "tc", pid 3248, jiffie