Re: [PATCH net] net/sched: act_mirred: fix fragment the packet after defrag in act_ct

2020-07-05 Thread Cong Wang
On Sun, Jul 5, 2020 at 7:33 AM wenxu wrote: > Thanks, I also think It is ok do fragment in the mirred output. Please stop doing it. There is no way to make this acceptable. You must be smart enough to find solutions elsewhere, possibly not even in TC at all. It would be best if you can solve thi

Re: [PATCH net] net/sched: act_mirred: fix fragment the packet after defrag in act_ct

2020-07-05 Thread Cong Wang
On Thu, Jul 2, 2020 at 5:47 PM Marcelo Ricardo Leitner wrote: > > in this case a act_output_it_well could do it. ;-) Yeah, still much better than making "mirred" do "mirror, redirect, frag, defrag", can't we all agree it is too late to rename mirred? :) Please do not try to add any arbitrary fun

Re: [PATCH net] net/sched: act_mirred: fix fragment the packet after defrag in act_ct

2020-07-05 Thread wenxu
在 2020/7/4 1:50, Marcelo Ricardo Leitner 写道: > On Fri, Jul 03, 2020 at 06:19:51PM +0800, wenxu wrote: >> On 7/3/2020 8:47 AM, Marcelo Ricardo Leitner wrote: >>> On Thu, Jul 02, 2020 at 02:39:07PM -0700, Cong Wang wrote: On Thu, Jul 2, 2020 at 10:32 AM Marcelo Ricardo Leitner wrote: >>>

Re: [PATCH net] net/sched: act_mirred: fix fragment the packet after defrag in act_ct

2020-07-03 Thread Marcelo Ricardo Leitner
On Fri, Jul 03, 2020 at 06:19:51PM +0800, wenxu wrote: > > On 7/3/2020 8:47 AM, Marcelo Ricardo Leitner wrote: > > On Thu, Jul 02, 2020 at 02:39:07PM -0700, Cong Wang wrote: > >> On Thu, Jul 2, 2020 at 10:32 AM Marcelo Ricardo Leitner > >> wrote: > >>> On Thu, Jul 02, 2020 at 05:36:38PM +0800, we

Re: [PATCH net] net/sched: act_mirred: fix fragment the packet after defrag in act_ct

2020-07-03 Thread wenxu
On 7/3/2020 8:47 AM, Marcelo Ricardo Leitner wrote: > On Thu, Jul 02, 2020 at 02:39:07PM -0700, Cong Wang wrote: >> On Thu, Jul 2, 2020 at 10:32 AM Marcelo Ricardo Leitner >> wrote: >>> On Thu, Jul 02, 2020 at 05:36:38PM +0800, wenxu wrote: On 7/2/2020 1:33 AM, Cong Wang wrote: > On Wed

Re: [PATCH net] net/sched: act_mirred: fix fragment the packet after defrag in act_ct

2020-07-02 Thread Marcelo Ricardo Leitner
On Thu, Jul 02, 2020 at 02:39:07PM -0700, Cong Wang wrote: > On Thu, Jul 2, 2020 at 10:32 AM Marcelo Ricardo Leitner > wrote: > > > > On Thu, Jul 02, 2020 at 05:36:38PM +0800, wenxu wrote: > > > > > > On 7/2/2020 1:33 AM, Cong Wang wrote: > > > > On Wed, Jul 1, 2020 at 1:21 AM wenxu wrote: > > >

Re: [PATCH net] net/sched: act_mirred: fix fragment the packet after defrag in act_ct

2020-07-02 Thread Cong Wang
On Thu, Jul 2, 2020 at 10:32 AM Marcelo Ricardo Leitner wrote: > > On Thu, Jul 02, 2020 at 05:36:38PM +0800, wenxu wrote: > > > > On 7/2/2020 1:33 AM, Cong Wang wrote: > > > On Wed, Jul 1, 2020 at 1:21 AM wenxu wrote: > > >> > > >> On 7/1/2020 2:21 PM, wenxu wrote: > > >>> On 7/1/2020 2:12 PM, Co

Re: [PATCH net] net/sched: act_mirred: fix fragment the packet after defrag in act_ct

2020-07-02 Thread Marcelo Ricardo Leitner
On Thu, Jul 02, 2020 at 05:36:38PM +0800, wenxu wrote: > > On 7/2/2020 1:33 AM, Cong Wang wrote: > > On Wed, Jul 1, 2020 at 1:21 AM wenxu wrote: > >> > >> On 7/1/2020 2:21 PM, wenxu wrote: > >>> On 7/1/2020 2:12 PM, Cong Wang wrote: > On Tue, Jun 30, 2020 at 11:03 PM wenxu wrote: > > On

Re: [PATCH net] net/sched: act_mirred: fix fragment the packet after defrag in act_ct

2020-07-02 Thread wenxu
On 7/2/2020 1:33 AM, Cong Wang wrote: > On Wed, Jul 1, 2020 at 1:21 AM wenxu wrote: >> >> On 7/1/2020 2:21 PM, wenxu wrote: >>> On 7/1/2020 2:12 PM, Cong Wang wrote: On Tue, Jun 30, 2020 at 11:03 PM wenxu wrote: > Only forward packet case need do fragment again and there is no need do

Re: [PATCH net] net/sched: act_mirred: fix fragment the packet after defrag in act_ct

2020-07-01 Thread Cong Wang
On Wed, Jul 1, 2020 at 1:21 AM wenxu wrote: > > > On 7/1/2020 2:21 PM, wenxu wrote: > > On 7/1/2020 2:12 PM, Cong Wang wrote: > >> On Tue, Jun 30, 2020 at 11:03 PM wenxu wrote: > >>> Only forward packet case need do fragment again and there is no need do > >>> defrag explicit. > >> Same question

Re: [PATCH net] net/sched: act_mirred: fix fragment the packet after defrag in act_ct

2020-07-01 Thread wenxu
On 7/1/2020 2:21 PM, wenxu wrote: > On 7/1/2020 2:12 PM, Cong Wang wrote: >> On Tue, Jun 30, 2020 at 11:03 PM wenxu wrote: >>> Only forward packet case need do fragment again and there is no need do >>> defrag explicit. >> Same question: why act_mirred? You have to explain why act_mirred >> has

Re: [PATCH net] net/sched: act_mirred: fix fragment the packet after defrag in act_ct

2020-06-30 Thread wenxu
On 7/1/2020 2:12 PM, Cong Wang wrote: > On Tue, Jun 30, 2020 at 11:03 PM wenxu wrote: >> Only forward packet case need do fragment again and there is no need do >> defrag explicit. > Same question: why act_mirred? You have to explain why act_mirred > has the responsibility to do this job. The

Re: [PATCH net] net/sched: act_mirred: fix fragment the packet after defrag in act_ct

2020-06-30 Thread Cong Wang
On Tue, Jun 30, 2020 at 11:03 PM wenxu wrote: > > Only forward packet case need do fragment again and there is no need do > defrag explicit. Same question: why act_mirred? You have to explain why act_mirred has the responsibility to do this job. Thanks.

Re: [PATCH net] net/sched: act_mirred: fix fragment the packet after defrag in act_ct

2020-06-30 Thread wenxu
On 7/1/2020 1:52 PM, Cong Wang wrote: > On Tue, Jun 30, 2020 at 7:36 PM wenxu wrote: >> >> On 7/1/2020 3:02 AM, Cong Wang wrote: >>> On Mon, Jun 29, 2020 at 7:55 PM wrote: From: wenxu The fragment packets do defrag in act_ct module. The reassembled packet over the mtu in th

Re: [PATCH net] net/sched: act_mirred: fix fragment the packet after defrag in act_ct

2020-06-30 Thread Cong Wang
On Tue, Jun 30, 2020 at 7:36 PM wenxu wrote: > > > On 7/1/2020 3:02 AM, Cong Wang wrote: > > On Mon, Jun 29, 2020 at 7:55 PM wrote: > >> From: wenxu > >> > >> The fragment packets do defrag in act_ct module. The reassembled packet > >> over the mtu in the act_mirred. This big packet should be fr

Re: [PATCH net] net/sched: act_mirred: fix fragment the packet after defrag in act_ct

2020-06-30 Thread wenxu
On 7/1/2020 3:02 AM, Cong Wang wrote: > On Mon, Jun 29, 2020 at 7:55 PM wrote: >> From: wenxu >> >> The fragment packets do defrag in act_ct module. The reassembled packet >> over the mtu in the act_mirred. This big packet should be fragmented >> to send out. > This is too brief. Why act_mirred

Re: [PATCH net] net/sched: act_mirred: fix fragment the packet after defrag in act_ct

2020-06-30 Thread wenxu
On 6/30/2020 11:57 PM, Eric Dumazet wrote: > > On 6/29/20 7:54 PM, we...@ucloud.cn wrote: >> From: wenxu >> >> The fragment packets do defrag in act_ct module. The reassembled packet >> over the mtu in the act_mirred. This big packet should be fragmented >> to send out. >> >> Fixes: b57dc7c13ea9

Re: [PATCH net] net/sched: act_mirred: fix fragment the packet after defrag in act_ct

2020-06-30 Thread Cong Wang
On Mon, Jun 29, 2020 at 7:55 PM wrote: > > From: wenxu > > The fragment packets do defrag in act_ct module. The reassembled packet > over the mtu in the act_mirred. This big packet should be fragmented > to send out. This is too brief. Why act_mirred should handle the burden introduced by act_ct

Re: [PATCH net] net/sched: act_mirred: fix fragment the packet after defrag in act_ct

2020-06-30 Thread Eric Dumazet
On 6/29/20 7:54 PM, we...@ucloud.cn wrote: > From: wenxu > > The fragment packets do defrag in act_ct module. The reassembled packet > over the mtu in the act_mirred. This big packet should be fragmented > to send out. > > Fixes: b57dc7c13ea9 ("net/sched: Introduce action ct") > Signed-off-by

[PATCH net] net/sched: act_mirred: fix fragment the packet after defrag in act_ct

2020-06-29 Thread wenxu
From: wenxu The fragment packets do defrag in act_ct module. The reassembled packet over the mtu in the act_mirred. This big packet should be fragmented to send out. Fixes: b57dc7c13ea9 ("net/sched: Introduce action ct") Signed-off-by: wenxu --- This patch is based on http://patchwork.ozlabs.or