Re: [PATCH net] net/mlx5e: Do not recycle pages from emergency reserve

2017-01-24 Thread Saeed Mahameed
On Sun, Jan 22, 2017 at 7:50 PM, Tom Herbert wrote: > On Sat, Jan 21, 2017 at 12:31 PM, Saeed Mahameed > wrote: >> On Sat, Jan 21, 2017 at 9:12 PM, kernel netdev wrote: >>> >>> >>> Den 21. jan. 2017 7.10 PM skrev "Tom Herbert" : >>> >>> On Thu, Jan 19, 2017 at 11:14 AM, Saeed Mahameed >>> wrote

Re: [PATCH net] net/mlx5e: Do not recycle pages from emergency reserve

2017-01-24 Thread Saeed Mahameed
On Mon, Jan 23, 2017 at 11:14 AM, Jesper Dangaard Brouer wrote: > On Sat, 21 Jan 2017 11:26:49 -0800 > Eric Dumazet wrote: > >> > My previous measurements show approx 20℅ speedup on a UDP test with >> > delivery to remote CPU. >> > >> I find this a bit strange. When you have time (ie not while dr

Re: [PATCH net] net/mlx5e: Do not recycle pages from emergency reserve

2017-01-23 Thread David Miller
From: Jesper Dangaard Brouer Date: Mon, 23 Jan 2017 09:39:40 +0100 > BUT there are other advantages of using a guaranteed recycle pool > facility (like the page_pool). Namely, (1) DMA-overhead: keeping page > DMA mapped to counter DMA+IOMMU overhead, (2) RX-zero-copy: opens up > for a software m

Re: [PATCH net] net/mlx5e: Do not recycle pages from emergency reserve

2017-01-23 Thread Jesper Dangaard Brouer
On Sat, 21 Jan 2017 11:26:49 -0800 Eric Dumazet wrote: > > My previous measurements show approx 20℅ speedup on a UDP test with > > delivery to remote CPU. > > > I find this a bit strange. When you have time (ie not while driving your > car or during week end) please give more details, for exam

Re: [PATCH net] net/mlx5e: Do not recycle pages from emergency reserve

2017-01-23 Thread Jesper Dangaard Brouer
On Sat, 21 Jan 2017 22:31:26 +0200 Saeed Mahameed wrote: > > My previous measurements show approx 20℅ speedup on a UDP test with delivery > > to remote CPU. > > > > Removing the cache would of cause be a good usecase for speeding up the page > > allocator (PCP). Which Mel Gorman and me are work

Re: [PATCH net] net/mlx5e: Do not recycle pages from emergency reserve

2017-01-22 Thread Tom Herbert
On Sat, Jan 21, 2017 at 11:12 AM, kernel netdev wrote: > > > Den 21. jan. 2017 7.10 PM skrev "Tom Herbert" : > > On Thu, Jan 19, 2017 at 11:14 AM, Saeed Mahameed > wrote: >> On Thu, Jan 19, 2017 at 9:03 AM, Eric Dumazet >> wrote: >>> From: Eric Dumazet >>> >>> A driver using dev_alloc_page() mu

Re: [PATCH net] net/mlx5e: Do not recycle pages from emergency reserve

2017-01-22 Thread Tom Herbert
On Sat, Jan 21, 2017 at 12:31 PM, Saeed Mahameed wrote: > On Sat, Jan 21, 2017 at 9:12 PM, kernel netdev wrote: >> >> >> Den 21. jan. 2017 7.10 PM skrev "Tom Herbert" : >> >> On Thu, Jan 19, 2017 at 11:14 AM, Saeed Mahameed >> wrote: >>> On Thu, Jan 19, 2017 at 9:03 AM, Eric Dumazet >>> wrote:

Re: [PATCH net] net/mlx5e: Do not recycle pages from emergency reserve

2017-01-21 Thread Saeed Mahameed
On Sat, Jan 21, 2017 at 9:12 PM, kernel netdev wrote: > > > Den 21. jan. 2017 7.10 PM skrev "Tom Herbert" : > > On Thu, Jan 19, 2017 at 11:14 AM, Saeed Mahameed > wrote: >> On Thu, Jan 19, 2017 at 9:03 AM, Eric Dumazet >> wrote: >>> From: Eric Dumazet >>> >>> A driver using dev_alloc_page() mus

Re: [PATCH net] net/mlx5e: Do not recycle pages from emergency reserve

2017-01-21 Thread Eric Dumazet
On Sat, 2017-01-21 at 20:12 +0100, kernel netdev wrote: > > > Den 21. jan. 2017 7.10 PM skrev "Tom Herbert" : > On Thu, Jan 19, 2017 at 11:14 AM, Saeed Mahameed > wrote: > > On Thu, Jan 19, 2017 at 9:03 AM, Eric Dumazet > wrote: > >> From: Eric Dumazet >

Re: [PATCH net] net/mlx5e: Do not recycle pages from emergency reserve

2017-01-21 Thread Tom Herbert
On Thu, Jan 19, 2017 at 11:14 AM, Saeed Mahameed wrote: > On Thu, Jan 19, 2017 at 9:03 AM, Eric Dumazet wrote: >> From: Eric Dumazet >> >> A driver using dev_alloc_page() must not reuse a page allocated from >> emergency memory reserve. >> >> Otherwise all packets using this page will be immedia

Re: [PATCH net] net/mlx5e: Do not recycle pages from emergency reserve

2017-01-20 Thread David Miller
From: Eric Dumazet Date: Wed, 18 Jan 2017 23:03:08 -0800 > From: Eric Dumazet > > A driver using dev_alloc_page() must not reuse a page allocated from > emergency memory reserve. > > Otherwise all packets using this page will be immediately dropped, > unless for very specific sockets having SO

Re: [PATCH net] net/mlx5e: Do not recycle pages from emergency reserve

2017-01-20 Thread Saeed Mahameed
On Thu, Jan 19, 2017 at 9:03 AM, Eric Dumazet wrote: > From: Eric Dumazet > > A driver using dev_alloc_page() must not reuse a page allocated from > emergency memory reserve. > > Otherwise all packets using this page will be immediately dropped, > unless for very specific sockets having SOCK_MEMA

Re: [PATCH net] net/mlx5e: Do not recycle pages from emergency reserve

2017-01-19 Thread Saeed Mahameed
On Thu, Jan 19, 2017 at 9:25 PM, Eric Dumazet wrote: > On Thu, 2017-01-19 at 21:14 +0200, Saeed Mahameed wrote: >> On Thu, Jan 19, 2017 at 9:03 AM, Eric Dumazet wrote: >> > From: Eric Dumazet >> > >> > A driver using dev_alloc_page() must not reuse a page allocated from >> > emergency memory res

Re: [PATCH net] net/mlx5e: Do not recycle pages from emergency reserve

2017-01-19 Thread Eric Dumazet
On Thu, 2017-01-19 at 21:14 +0200, Saeed Mahameed wrote: > On Thu, Jan 19, 2017 at 9:03 AM, Eric Dumazet wrote: > > From: Eric Dumazet > > > > A driver using dev_alloc_page() must not reuse a page allocated from > > emergency memory reserve. > > > > Otherwise all packets using this page will be i

Re: [PATCH net] net/mlx5e: Do not recycle pages from emergency reserve

2017-01-19 Thread Saeed Mahameed
On Thu, Jan 19, 2017 at 9:03 AM, Eric Dumazet wrote: > From: Eric Dumazet > > A driver using dev_alloc_page() must not reuse a page allocated from > emergency memory reserve. > > Otherwise all packets using this page will be immediately dropped, > unless for very specific sockets having SOCK_MEMA

[PATCH net] net/mlx5e: Do not recycle pages from emergency reserve

2017-01-18 Thread Eric Dumazet
From: Eric Dumazet A driver using dev_alloc_page() must not reuse a page allocated from emergency memory reserve. Otherwise all packets using this page will be immediately dropped, unless for very specific sockets having SOCK_MEMALLOC bit set. This issue might be hard to debug, because only a f