Re: [PATCH net] net/ipv6: Do not allow device only routes via the multipath API

2018-07-13 Thread David Ahern
On 7/13/18 7:28 AM, Stefano Brivio wrote: > On Thu, 12 Jul 2018 14:48:23 -0700 > dsah...@kernel.org wrote: > >> @@ -4388,6 +4388,13 @@ static int ip6_route_multipath_add(struct fib6_config >> *cfg, >> rt = NULL; >> goto cleanup; >> } >> +

Re: [PATCH net] net/ipv6: Do not allow device only routes via the multipath API

2018-07-13 Thread Stefano Brivio
On Thu, 12 Jul 2018 14:48:23 -0700 dsah...@kernel.org wrote: > @@ -4388,6 +4388,13 @@ static int ip6_route_multipath_add(struct fib6_config > *cfg, > rt = NULL; > goto cleanup; > } > + if (!rt6_qualify_for_ecmp(rt)) { > +

[PATCH net] net/ipv6: Do not allow device only routes via the multipath API

2018-07-12 Thread dsahern
From: David Ahern Eric reported that reverting the patch that fixed and simplified IPv6 multipath routes means reverting back to invalid userspace notifications. eg., $ ip -6 route add 2001:db8:1::/64 nexthop dev eth0 nexthop dev eth1 only generates a single notification: 2001:db8:1::/64 dev eth