Re: [PATCH net] net/act_pedit: fix an error code

2017-06-14 Thread David Miller
From: Dan Carpenter Date: Wed, 14 Jun 2017 13:29:31 +0300 > I'm reviewing static checker warnings where we do ERR_PTR(0), which is > the same as NULL. I'm pretty sure we intended to return ERR_PTR(-EINVAL) > here. Sometimes these bugs lead to a NULL dereference but I don't > immediately see tha

Re: [PATCH net] net/act_pedit: fix an error code

2017-06-14 Thread Amir Vadai
On Wed, Jun 14, 2017 at 01:29:31PM +0300, Dan Carpenter wrote: > I'm reviewing static checker warnings where we do ERR_PTR(0), which is > the same as NULL. I'm pretty sure we intended to return ERR_PTR(-EINVAL) > here. Sometimes these bugs lead to a NULL dereference but I don't > immediately see

[PATCH net] net/act_pedit: fix an error code

2017-06-14 Thread Dan Carpenter
I'm reviewing static checker warnings where we do ERR_PTR(0), which is the same as NULL. I'm pretty sure we intended to return ERR_PTR(-EINVAL) here. Sometimes these bugs lead to a NULL dereference but I don't immediately see that problem here. Fixes: 71d0ed7079df ("net/act_pedit: Support using