Re: [PATCH net] mptcp: fix NULL ptr dereference on bad MPJ

2020-11-27 Thread Jakub Kicinski
On Thu, 26 Nov 2020 16:23:08 +0100 Matthieu Baerts wrote: > On 26/11/2020 15:17, Paolo Abeni wrote: > > If an msk listener receives an MPJ carrying an invalid token, it > > will zero the request socket msk entry. That should later > > cause fallback and subflow reset - as per RFC - at > > subflow_s

Re: [PATCH net] mptcp: fix NULL ptr dereference on bad MPJ

2020-11-26 Thread Matthieu Baerts
Hi Paolo, On 26/11/2020 15:17, Paolo Abeni wrote: If an msk listener receives an MPJ carrying an invalid token, it will zero the request socket msk entry. That should later cause fallback and subflow reset - as per RFC - at subflow_syn_recv_sock() time due to failing hmac validation. Since comm

[PATCH net] mptcp: fix NULL ptr dereference on bad MPJ

2020-11-26 Thread Paolo Abeni
If an msk listener receives an MPJ carrying an invalid token, it will zero the request socket msk entry. That should later cause fallback and subflow reset - as per RFC - at subflow_syn_recv_sock() time due to failing hmac validation. Since commit 4cf8b7e48a09 ("subflow: introduce and use mptcp_ca