Re: [PATCH net] mlx4: xdp_prog becomes inactive after ethtool '-L' or '-G'

2017-01-31 Thread Martin KaFai Lau
On Mon, Jan 30, 2017 at 07:18:28PM +0200, Tariq Toukan wrote: > Hi Martin, > > Thanks for your patch. > > It looks good to me, in general. > I just have one small comment below. Thanks for your feedback and sorry for the delay. > > On 28/01/2017 9:40 AM, Martin KaFai Lau wrote: > > If the rx-queue

Re: [PATCH net] mlx4: xdp_prog becomes inactive after ethtool '-L' or '-G'

2017-01-31 Thread Martin KaFai Lau
On Tue, Jan 31, 2017 at 01:11:40PM -0500, David Miller wrote: > From: Tariq Toukan > Date: Mon, 30 Jan 2017 19:18:28 +0200 > > > It looks good to me, in general. > > I just have one small comment below. > > Martin, please address Tariq's feedback. Sorry for the delay. I am on PTO for this week an

Re: [PATCH net] mlx4: xdp_prog becomes inactive after ethtool '-L' or '-G'

2017-01-31 Thread David Miller
From: Tariq Toukan Date: Mon, 30 Jan 2017 19:18:28 +0200 > It looks good to me, in general. > I just have one small comment below. Martin, please address Tariq's feedback. Thank you.

Re: [PATCH net] mlx4: xdp_prog becomes inactive after ethtool '-L' or '-G'

2017-01-30 Thread Tariq Toukan
Hi Martin, Thanks for your patch. It looks good to me, in general. I just have one small comment below. On 28/01/2017 9:40 AM, Martin KaFai Lau wrote: If the rx-queues ever get re-initialized (e.g. by changing the number of rx-queues with ethtool -L), the existing xdp_prog becomes inactive. T

Re: [PATCH net] mlx4: xdp_prog becomes inactive after ethtool '-L' or '-G'

2017-01-30 Thread David Miller
From: Martin KaFai Lau Date: Fri, 27 Jan 2017 23:40:51 -0800 > If the rx-queues ever get re-initialized (e.g. by changing the > number of rx-queues with ethtool -L), the existing xdp_prog becomes > inactive. > > The bug is that the xdp_prog ptr has not been carried over from > the old rx-queues

[PATCH net] mlx4: xdp_prog becomes inactive after ethtool '-L' or '-G'

2017-01-28 Thread Martin KaFai Lau
If the rx-queues ever get re-initialized (e.g. by changing the number of rx-queues with ethtool -L), the existing xdp_prog becomes inactive. The bug is that the xdp_prog ptr has not been carried over from the old rx-queues to the new rx-queues Fixes: 47a38e155037 ("net/mlx4_en: add support for fa