Re: [PATCH net] mlx4: TCP/UDP packets have L4 hash

2015-07-08 Thread David Miller
From: Eric Dumazet Date: Thu, 02 Jul 2015 13:24:44 +0200 > From: Eric Dumazet > > Mellanox driver has the knowledge if rxhash is a L4 hash, > if it receives a non fragmented TCP or UDP frame and > NETIF_F_RXCSUM is enabled on netdev. > > ip_summed value is CHECKSUM_UNNECESSARY in this case. >

Re: [PATCH net] mlx4: TCP/UDP packets have L4 hash

2015-07-05 Thread Ido Shamay
On 7/6/2015 12:33 AM, Eric Dumazet wrote: On Mon, 2015-07-06 at 00:16 +0300, Ido Shamay wrote: We can have a relaxation of the condition by looking only at TCP/UDP CQE indication (without check-sum indications) This can cover us also when device rx-checksuming feature is off. Do we want it or

Re: [PATCH net] mlx4: TCP/UDP packets have L4 hash

2015-07-05 Thread Eric Dumazet
On Mon, 2015-07-06 at 00:16 +0300, Ido Shamay wrote: > We can have a relaxation of the condition by looking only at TCP/UDP > CQE indication (without check-sum indications) > This can cover us also when device rx-checksuming feature is off. > Do we want it or a correlation between check-sum and

Re: [PATCH net] mlx4: TCP/UDP packets have L4 hash

2015-07-05 Thread Ido Shamay
On 7/2/2015 2:24 PM, Eric Dumazet wrote: From: Eric Dumazet Mellanox driver has the knowledge if rxhash is a L4 hash, if it receives a non fragmented TCP or UDP frame and NETIF_F_RXCSUM is enabled on netdev. ip_summed value is CHECKSUM_UNNECESSARY in this case. Signed-off-by: Eric Dumazet Cc

[PATCH net] mlx4: TCP/UDP packets have L4 hash

2015-07-02 Thread Eric Dumazet
From: Eric Dumazet Mellanox driver has the knowledge if rxhash is a L4 hash, if it receives a non fragmented TCP or UDP frame and NETIF_F_RXCSUM is enabled on netdev. ip_summed value is CHECKSUM_UNNECESSARY in this case. Signed-off-by: Eric Dumazet Cc: Amir Vadai Cc: Ido Shamay --- drivers/