Re: [PATCH net] l2tp: fix l2tp_eth module loading

2017-10-01 Thread David Miller
From: Guillaume Nault Date: Thu, 28 Sep 2017 15:44:38 +0200 > The l2tp_eth module crashes if its netlink callbacks are run when the > pernet data aren't initialised. > > We should normally register_pernet_device() before the genl callbacks. > However, the pernet data only maintain a list of l2tp

Re: [PATCH net] l2tp: fix l2tp_eth module loading

2017-09-28 Thread Guillaume Nault
On Thu, Sep 28, 2017 at 03:17:28PM +0100, Tom Parkin wrote: > On Thu, Sep 28, 2017 at 03:44:38PM +0200, Guillaume Nault wrote: > > The l2tp_eth module crashes if its netlink callbacks are run when the > > pernet data aren't initialised. > > > > We should normally register_pernet_device() before th

Re: [PATCH net] l2tp: fix l2tp_eth module loading

2017-09-28 Thread Tom Parkin
On Thu, Sep 28, 2017 at 03:44:38PM +0200, Guillaume Nault wrote: > The l2tp_eth module crashes if its netlink callbacks are run when the > pernet data aren't initialised. > > We should normally register_pernet_device() before the genl callbacks. > However, the pernet data only maintain a list of l

[PATCH net] l2tp: fix l2tp_eth module loading

2017-09-28 Thread Guillaume Nault
The l2tp_eth module crashes if its netlink callbacks are run when the pernet data aren't initialised. We should normally register_pernet_device() before the genl callbacks. However, the pernet data only maintain a list of l2tpeth interfaces, and this list is never used. So let's just drop pernet h