On 11/26/2018 8:52 PM, David Miller wrote:
> From: Josh Elsasser
> Date: Mon, 26 Nov 2018 16:54:11 -0800
>
>> Jeff Kirsher wrote:
>>
>>> No need to re-spin the patch, just reply with the additional "Fixes"
>>> tag and if patchwork does not pick it up, I will add it to the patch I
>>> have in
On Mon, 2018-11-26 at 20:52 -0800, David Miller wrote:
> From: Josh Elsasser
> Date: Mon, 26 Nov 2018 16:54:11 -0800
>
> > Jeff Kirsher wrote:
> >
> > > No need to re-spin the patch, just reply with the additional
> > > "Fixes"
> > > tag and if patchwork does not pick it up, I will add it to th
From: Josh Elsasser
Date: Mon, 26 Nov 2018 16:54:11 -0800
> Jeff Kirsher wrote:
>
>> No need to re-spin the patch, just reply with the additional "Fixes"
>> tag and if patchwork does not pick it up, I will add it to the patch I
>> have in my tree for validation and review.
>
> Thanks, let’s tr
Jeff Kirsher wrote:
> No need to re-spin the patch, just reply with the additional "Fixes"
> tag and if patchwork does not pick it up, I will add it to the patch I
> have in my tree for validation and review.
Thanks, let’s try that.
Fixes: e23f33367882 ("ixgbe: Fix 1G and 10G link stability for
On Mon, 2018-11-26 at 09:54 -0800, Josh Elsasser wrote:
> Bjørn Mork wrote:
>
> > Not that it matters much I guess, but I think LX SFPs were
> > unsupported
> > at that time. The LX support appears to have been added under the
> > radar
> > while refactoring ixgbe_setup_sfp_modules_X550em in comm
Elsasser ; linux-ker...@vger.kernel.org
> Subject: [Intel-wired-lan] [PATCH net] ixgbe: recognize 1000BaseLX SFP
> modules as 1Gbps
>
> Add the two 1000BaseLX enum values to the X550's check for 1Gbps
> modules, allowing the core driver code to establish a link over this SFP type.
>
Bjørn Mork wrote:
> Not that it matters much I guess, but I think LX SFPs were unsupported
> at that time. The LX support appears to have been added under the radar
> while refactoring ixgbe_setup_sfp_modules_X550em in commit e23f33367882
> ("ixgbe: Fix 1G and 10G link stability for X550EM_x SFP+
Josh Elsasser writes:
> Fixes: 6a14ee0cfb19 ("ixgbe: Add X550 support function pointers")
Not that it matters much I guess, but I think LX SFPs were unsupported
at that time. The LX support appears to have been added under the radar
while refactoring ixgbe_setup_sfp_modules_X550em in commit e23f
Add the two 1000BaseLX enum values to the X550's check for 1Gbps modules,
allowing the core driver code to establish a link over this SFP type.
This is done by the out-of-tree driver but the fix wasn't in mainline.
Fixes: 6a14ee0cfb19 ("ixgbe: Add X550 support function pointers")
Signed-off-by: J
