Re: [PATCH net] ipv6: remove incorrect WARN_ON() in fib6_del()

2017-09-27 Thread Wei Wang
On Tue, Sep 26, 2017 at 6:20 AM, Eric Dumazet wrote: > On Mon, Sep 25, 2017 at 10:52 PM, Wei Wang wrote: >> On Mon, Sep 25, 2017 at 7:23 PM, Eric Dumazet wrote: >>> On Mon, Sep 25, 2017 at 7:07 PM, Martin KaFai Lau wrote: >>> I am probably still missing something. Considering the

Re: [PATCH net] ipv6: remove incorrect WARN_ON() in fib6_del()

2017-09-26 Thread Eric Dumazet
On Mon, Sep 25, 2017 at 10:52 PM, Wei Wang wrote: > On Mon, Sep 25, 2017 at 7:23 PM, Eric Dumazet wrote: >> On Mon, Sep 25, 2017 at 7:07 PM, Martin KaFai Lau wrote: >> >>> I am probably still missing something. >>> >>> Considering the del operation should be under the writer lock, >>> if rt->rt6

Re: [PATCH net] ipv6: remove incorrect WARN_ON() in fib6_del()

2017-09-25 Thread Wei Wang
On Mon, Sep 25, 2017 at 7:23 PM, Eric Dumazet wrote: > On Mon, Sep 25, 2017 at 7:07 PM, Martin KaFai Lau wrote: > >> I am probably still missing something. >> >> Considering the del operation should be under the writer lock, >> if rt->rt6i_node should be NULL (for rt that has already been >> remo

Re: [PATCH net] ipv6: remove incorrect WARN_ON() in fib6_del()

2017-09-25 Thread Eric Dumazet
On Mon, Sep 25, 2017 at 7:07 PM, Martin KaFai Lau wrote: > I am probably still missing something. > > Considering the del operation should be under the writer lock, > if rt->rt6i_node should be NULL (for rt that has already been > removed from fib6), why this WARN_ON() is triggered? > > An exampl

Re: [PATCH net] ipv6: remove incorrect WARN_ON() in fib6_del()

2017-09-25 Thread Martin KaFai Lau
On Tue, Sep 26, 2017 at 01:16:05AM +, Wei Wang wrote: > On Mon, Sep 25, 2017 at 5:56 PM, Martin KaFai Lau wrote: > > On Mon, Sep 25, 2017 at 05:35:22PM +, Wei Wang wrote: > >> From: Wei Wang > >> > >> fib6_del() generates WARN_ON() when rt->dst.obsolete > 0. This does not > >> make sense

Re: [PATCH net] ipv6: remove incorrect WARN_ON() in fib6_del()

2017-09-25 Thread Wei Wang
On Mon, Sep 25, 2017 at 5:56 PM, Martin KaFai Lau wrote: > On Mon, Sep 25, 2017 at 05:35:22PM +, Wei Wang wrote: >> From: Wei Wang >> >> fib6_del() generates WARN_ON() when rt->dst.obsolete > 0. This does not >> make sense because it is possible that the route passed in is already >> deleted

Re: [PATCH net] ipv6: remove incorrect WARN_ON() in fib6_del()

2017-09-25 Thread Martin KaFai Lau
On Mon, Sep 25, 2017 at 05:35:22PM +, Wei Wang wrote: > From: Wei Wang > > fib6_del() generates WARN_ON() when rt->dst.obsolete > 0. This does not > make sense because it is possible that the route passed in is already > deleted by some other thread and rt->dst.obsolete is set to > DST_OBSOLE

[PATCH net] ipv6: remove incorrect WARN_ON() in fib6_del()

2017-09-25 Thread Wei Wang
From: Wei Wang fib6_del() generates WARN_ON() when rt->dst.obsolete > 0. This does not make sense because it is possible that the route passed in is already deleted by some other thread and rt->dst.obsolete is set to DST_OBSOLETE_DEAD. So this commit deletes this WARN_ON() and also remove the "#i